Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support target all detail #253

Merged
merged 7 commits into from
Oct 15, 2019
Merged

add support target all detail #253

merged 7 commits into from
Oct 15, 2019

Conversation

Eomm
Copy link
Member

@Eomm Eomm commented Sep 7, 2019

Adding details from Release WG feedback

Relates to #236

@mhdawson
Copy link
Member

I did not notice this before I created: #257. Would have added on to this one if I had, sorry.

@Eomm
Copy link
Member Author

Eomm commented Sep 13, 2019

I did not notice this before I created: #257. Would have added on to this one if I had, sorry.

May I include that commit in this PR?

@mhdawson
Copy link
Member

@Eomm sounds good, please do.

@mhdawson
Copy link
Member

@Eomm are you going to be able to pull in the commit from #257. If not I can try to do it the other way around.

@Eomm
Copy link
Member Author

Eomm commented Sep 25, 2019

@Eomm are you going to be able to pull in the commit from #257. If not I can try to do it the other way around.

Done, sorry for the delay 😅

Eomm and others added 3 commits October 5, 2019 12:21
@Eomm @dominykas @mhdawson
Apply suggestions from code review
cb692fe 
Co-Authored-By: Dominykas Blyžė <hello@dominykas.com>
Co-Authored-By: Michael Dawson <michael_dawson@ca.ibm.com>
@Eomm
fix far example
b18ac0c
@Eomm
add namespace table
f6a534f
@Eomm Eomm requested a review from dominykas October 9, 2019 18:45
mhdawson
mhdawson approved these changes Oct 10, 2019
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dominykas
Copy link
Member

dominykas commented Oct 10, 2019 •
edited
Loading

Added a couple more tweaks, as I still felt that active vs lts_active wording was a bit confusing. These are merely suggestions - there may be further scope for improvement.

@Eomm @dominykas
Apply suggestions from code review
c36557c 
Co-Authored-By: Dominykas Blyžė <hello@dominykas.com>
wesleytodd
wesleytodd approved these changes Oct 14, 2019
View reviewed changes
Copy link
Member

@wesleytodd wesleytodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving because the table changes are great!

@mhdawson mhdawson merged commit 8f5bd3f into nodejs:master Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb left review comments

@vweevers vweevers vweevers left review comments

@dominykas dominykas dominykas approved these changes

@wesleytodd wesleytodd wesleytodd approved these changes

@lholmquist lholmquist lholmquist approved these changes

@mhdawson mhdawson mhdawson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Eomm @mhdawson @dominykas @ljharb @wesleytodd @lholmquist @vweevers