Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Docs/issue 309 governance models #356

Merged

Conversation

thescientist13
Copy link
Contributor

resolves #309 (first draft)

docs/drafts/governance.md Outdated Show resolved Hide resolved
docs/drafts/governance.md Outdated Show resolved Hide resolved
docs/drafts/governance.md Outdated Show resolved Hide resolved
docs/drafts/governance.md Outdated Show resolved Hide resolved
docs/drafts/governance.md Outdated Show resolved Hide resolved
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with a few suggestions/typo corrections

@thescientist13 thescientist13 self-assigned this Jun 29, 2020
@thescientist13
Copy link
Contributor Author

Thanks for the extra 👀 @mhdawson , feedback applied! 😃

Copy link
Contributor

@ghinks ghinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @thescientist13.

Copy link
Contributor Author

@thescientist13 thescientist13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given our discussion around drafts in general in #373 , does anyone have any objection to me just moving this doc out of drafts on this first pass, and removing the draft "label" from the Table of Contents here?

Or should there be an incubation period of sorts for new documentation? I guess in general not sure what constitutes a draft (aside from those with only an outline / sparse content).

@mhdawson
Copy link
Member

mhdawson commented Jul 2, 2020

I'm happy for it to move out of draft as part of this PR.

thescientist13 and others added 12 commits July 4, 2020 13:33
Co-authored-by: Michael Dawson <michael_dawson@ca.ibm.com>
Co-authored-by: Michael Dawson <michael_dawson@ca.ibm.com>
Co-authored-by: Michael Dawson <michael_dawson@ca.ibm.com>
Co-authored-by: Michael Dawson <michael_dawson@ca.ibm.com>
Co-authored-by: Michael Dawson <michael_dawson@ca.ibm.com>
@thescientist13 thescientist13 force-pushed the docs/issue-309-governance-models branch from 8e4e1d1 to 2822ab9 Compare July 4, 2020 17:34
docs/governance.md Outdated Show resolved Hide resolved
Co-authored-by: Dominykas Blyžė <hello@dominykas.com>
@dominykas dominykas merged commit 685f0dc into nodejs:master Jul 14, 2020
@dominykas dominykas removed the package-maintenance-agenda Agenda items for package-maintenance team label Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC] Governance Models and Methodologies for Package Maintainers
5 participants