Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What to use for CI #62

Open
RaisinTen opened this issue Oct 28, 2022 · 7 comments
Open

What to use for CI #62

RaisinTen opened this issue Oct 28, 2022 · 7 comments
Labels
ci 🟢 question ❔ Further information is requested

Comments

@RaisinTen
Copy link
Contributor

Postject was using CircleCI under the Postman account and it got disconnected after the repo got transferred to the nodejs org. Now that CI doesn't work anymore, it's time to reconsider what we should use for CI:

  • use a CircleCI account from Node.js on the free tier
  • switch to Node.js' Jenkins CI
  • use GitHub Actions
  • something else

@nodejs/single-executable wdyt?

@jviotti
Copy link
Member

jviotti commented Oct 28, 2022

One of the eventual goals of Postject is the support AIX's XCOFF. Given that, it'd be cool if we can use a CI system that supports AIX. How does Node.js core do it? If there is AIX under Jenkins, is there any chance we could reuse that?

Otherwise, the simplest approach is probably GitHub Actions?

@mhdawson
Copy link
Member

Since this is under the Node.js org I suggest we use Node.js' Jenkins CI.

That is where we ensure we can test on all Node.js supported platform/versions. I can help set up a jenkins job. Ideally it would be as easy as clone this repo, then run make test or some equivalent, although I know it is often more complicated than that.

@mhdawson
Copy link
Member

And to answer @jviotti, yes we have instances of all supported platforms including AIX :)

@jviotti
Copy link
Member

jviotti commented Oct 28, 2022

Sounds exciting!

@RaisinTen
Copy link
Contributor Author

I can help set up a jenkins job.

Thanks, that sounds great! We would need a way to run https://github.com/nodejs/postject/blob/0d7aab19f2472f159c08802e67bfb4d64611ca1d/.circleci/config.yml on Jenkins.

@jviotti
Copy link
Member

jviotti commented Oct 31, 2022

@RaisinTen Jenkins won't be able to run the CircleCI config, of course. We would need to get rid of that .circleci folder, refactor these steps into i.e. shell scripts, and then configure Jenkins to run them instead.

@dsanders11 dsanders11 added question ❔ Further information is requested ci 🟢 labels Nov 9, 2022
RaisinTen added a commit to RaisinTen/build that referenced this issue Dec 14, 2022
Fixes: nodejs/postject#62
Signed-off-by: Darshan Sen <raisinten@gmail.com>
RaisinTen added a commit to RaisinTen/build that referenced this issue Dec 14, 2022
Fixes: nodejs/postject#62
Signed-off-by: Darshan Sen <raisinten@gmail.com>
@RaisinTen
Copy link
Contributor Author

@tony-go and I spent some time today to come up with a jenkins pipeline to unblock postject's development: nodejs/build#3114

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci 🟢 question ❔ Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants