Skip to content
This repository has been archived by the owner on Aug 11, 2020. It is now read-only.

quic: additional cleanups and fixups #294

Closed
wants to merge 8 commits into from
Closed

quic: additional cleanups and fixups #294

wants to merge 8 commits into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Jan 22, 2020

No description provided.

@jasnell jasnell force-pushed the additional-cleanup-jan22 branch from dda9318 to 65fe214 Compare January 22, 2020 19:58
addaleax
addaleax approved these changes Jan 22, 2020
View reviewed changes
src/quic/node_quic_session.h Outdated Show resolved Hide resolved
src/quic/node_quic_socket.cc Show resolved Hide resolved
src/quic/node_quic_socket.h Outdated Show resolved Hide resolved
src/quic/node_quic_stream.h Outdated Show resolved Hide resolved
src/quic/node_quic_stream.h Outdated Show resolved Hide resolved
src/quic/node_quic_stream.h Outdated Show resolved Hide resolved
addaleax
addaleax reviewed Jan 22, 2020
View reviewed changes
src/quic/node_quic_util.h Outdated Show resolved Hide resolved
src/quic/node_quic_util.h Show resolved Hide resolved
@jasnell jasnell force-pushed the additional-cleanup-jan22 branch from 1fa54f7 to 22d3981 Compare January 22, 2020 22:23
addaleax
addaleax approved these changes Jan 23, 2020
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think this is a bit nicer than the double-template approach :)

@jasnell jasnell force-pushed the additional-cleanup-jan22 branch 2 times, most recently from 9e495d4 to 5903361 Compare January 23, 2020 14:36
@jasnell jasnell force-pushed the additional-cleanup-jan22 branch from 5903361 to 5c2a8bd Compare January 23, 2020 14:56
jasnell added a commit that referenced this pull request Jan 23, 2020
@jasnell
quic: unify stateless reset handling
3982f88 
PR-URL: #294
Reviewed-By: Anna Henningsen <anna@addaleax.net>
jasnell added a commit that referenced this pull request Jan 23, 2020
@jasnell
quic: use ToString in prep for FPrintF
58c73d1 
PR-URL: #294
Reviewed-By: Anna Henningsen <anna@addaleax.net>
jasnell added a commit that referenced this pull request Jan 23, 2020
@jasnell
quic: move Map types into relevant classes
7fbcec0 
PR-URL: #294
Reviewed-By: Anna Henningsen <anna@addaleax.net>
jasnell added a commit that referenced this pull request Jan 23, 2020
@jasnell
quic: more prep for FPrintF
e0bde6b 
PR-URL: #294
Reviewed-By: Anna Henningsen <anna@addaleax.net>
jasnell added a commit that referenced this pull request Jan 23, 2020
@jasnell
quic: refactor finalSize
9136b2d 
Fixes: #65
PR-URL: #294
Reviewed-By: Anna Henningsen <anna@addaleax.net>
jasnell added a commit that referenced this pull request Jan 23, 2020
@jasnell
quic: additional QuicStream tracking stats
cdac96d 
PR-URL: #294
Reviewed-By: Anna Henningsen <anna@addaleax.net>
jasnell added a commit that referenced this pull request Jan 23, 2020
@jasnell
quic: add ToString to QuicHeader in prep for FPrintF
1ec0ffd 
PR-URL: #294
Reviewed-By: Anna Henningsen <anna@addaleax.net>
jasnell added a commit that referenced this pull request Jan 23, 2020
@jasnell
quic: further refinement to StatsDebug
0c4665f 
PR-URL: #294
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@jasnell
Copy link
Member Author

jasnell commented Jan 23, 2020

Landed

@jasnell jasnell closed this Jan 23, 2020
jasnell added a commit to jasnell/quic that referenced this pull request Feb 3, 2020
@jasnell
quic: unify stateless reset handling
0a974c0 
PR-URL: nodejs#294
Reviewed-By: Anna Henningsen <anna@addaleax.net>
jasnell added a commit to jasnell/quic that referenced this pull request Feb 3, 2020
@jasnell
quic: use ToString in prep for FPrintF
a088a97 
PR-URL: nodejs#294
Reviewed-By: Anna Henningsen <anna@addaleax.net>
jasnell added a commit to jasnell/quic that referenced this pull request Feb 3, 2020
@jasnell
quic: move Map types into relevant classes
e67decb 
PR-URL: nodejs#294
Reviewed-By: Anna Henningsen <anna@addaleax.net>
jasnell added a commit to jasnell/quic that referenced this pull request Feb 3, 2020
@jasnell
quic: more prep for FPrintF
2fee835 
PR-URL: nodejs#294
Reviewed-By: Anna Henningsen <anna@addaleax.net>
jasnell added a commit to jasnell/quic that referenced this pull request Feb 3, 2020
@jasnell
quic: refactor finalSize
645b1d1 
Fixes: nodejs#65
PR-URL: nodejs#294
Reviewed-By: Anna Henningsen <anna@addaleax.net>
jasnell added a commit to jasnell/quic that referenced this pull request Feb 3, 2020
@jasnell
quic: additional QuicStream tracking stats
a41e830 
PR-URL: nodejs#294
Reviewed-By: Anna Henningsen <anna@addaleax.net>
jasnell added a commit to jasnell/quic that referenced this pull request Feb 3, 2020
@jasnell
quic: add ToString to QuicHeader in prep for FPrintF
d021dc2 
PR-URL: nodejs#294
Reviewed-By: Anna Henningsen <anna@addaleax.net>
jasnell added a commit to jasnell/quic that referenced this pull request Feb 3, 2020
@jasnell
quic: further refinement to StatsDebug
5a58469 
PR-URL: nodejs#294
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jasnell @addaleax