chore: use node version 18.19.0

README.md

@@ -11,9 +11,9 @@
 npm install readable-stream
 ```
 
-This package is a mirror of the streams implementations in Node.js 18.20.5.
+This package is a mirror of the streams implementations in Node.js 18.19.0.
 
-Full documentation may be found on the [Node.js website](https://nodejs.org/dist/v18.20.5/docs/api/stream.html).
+Full documentation may be found on the [Node.js website](https://nodejs.org/dist/v18.19.0/docs/api/stream.html).
 
 If you want to guarantee a stable streams base, regardless of what version of
 Node you, or the users of your libraries are using, use **readable-stream** _only_ and avoid the _"stream"_ module in Node-core, for background see [this blogpost](http://r.va.gg/2014/06/why-i-dont-use-nodes-core-stream-module.html).

lib/internal/streams/destroy.js

@@ -225,7 +225,7 @@ function constructNT(stream) {
     } else if (err) {
       errorOrDestroy(stream, err, true)
     } else {
-      stream.emit(kConstruct)
+      process.nextTick(emitConstructNT, stream)
     }
   }
   try {
@@ -236,6 +236,9 @@ function constructNT(stream) {
     process.nextTick(onConstruct, err)
   }
 }
+function emitConstructNT(stream) {
+  stream.emit(kConstruct)
+}
 function isRequest(stream) {
   return (stream === null || stream === undefined ? undefined : stream.setHeader) && typeof stream.abort === 'function'
 }

package.json

@@ -33,7 +33,7 @@
     "./lib/ours/index.js": "./lib/ours/browser.js"
   },
   "scripts": {
-    "build": "node build/build.mjs 18.20.5",
+    "build": "node build/build.mjs 18.19.0",
     "postbuild": "prettier -w lib test",
     "test": "tap --rcfile=./tap.yml test/parallel/test-*.js test/ours/test-*.js",
     "test:prepare": "node test/browser/runner-prepare.mjs",

test/common/index.js

@@ -45,24 +45,8 @@ const { atob, btoa } = require('buffer')
 if (isMainThread) process.umask(0o022)
 const noop = () => {}
 const hasCrypto = Boolean(process.versions.openssl) && !process.env.NODE_SKIP_CRYPTO
-
-// Synthesize OPENSSL_VERSION_NUMBER format with the layout 0xMNN00PPSL
-const opensslVersionNumber = (major = 0, minor = 0, patch = 0) => {
-  assert(major >= 0 && major <= 0xf)
-  assert(minor >= 0 && minor <= 0xff)
-  assert(patch >= 0 && patch <= 0xff)
-  return (major << 28) | (minor << 20) | (patch << 4)
-}
-let OPENSSL_VERSION_NUMBER
-const hasOpenSSL = (major = 0, minor = 0, patch = 0) => {
-  if (!hasCrypto) return false
-  if (OPENSSL_VERSION_NUMBER === undefined) {
-    const regexp = /(?<m>\d+)\.(?<n>\d+)\.(?<p>\d+)/
-    const { m, n, p } = process.versions.openssl.match(regexp).groups
-    OPENSSL_VERSION_NUMBER = opensslVersionNumber(m, n, p)
-  }
-  return OPENSSL_VERSION_NUMBER >= opensslVersionNumber(major, minor, patch)
-}
+const hasOpenSSL3 = hasCrypto && require('crypto').constants.OPENSSL_VERSION_NUMBER >= 0x30000000
+const hasOpenSSL31 = hasCrypto && require('crypto').constants.OPENSSL_VERSION_NUMBER >= 0x30100000
 const hasQuic = hasCrypto && !!process.config.variables.openssl_quic
 function parseTestFlags(filename = process.argv[1]) {
   // The copyright notice is relatively big and the flags could come afterwards.
@@ -842,7 +826,8 @@ const common = {
   getTTYfd,
   hasIntl,
   hasCrypto,
-  hasOpenSSL,
+  hasOpenSSL3,
+  hasOpenSSL31,
   hasQuic,
   hasMultiLocalhost,
   invalidArgTypeHelper,
@@ -898,15 +883,6 @@ const common = {
       return re.test(name) && iFaces[name].some(({ family }) => family === 'IPv6')
     })
   },
-  get hasOpenSSL3() {
-    return hasOpenSSL(3)
-  },
-  get hasOpenSSL31() {
-    return hasOpenSSL(3, 1)
-  },
-  get hasOpenSSL32() {
-    return hasOpenSSL(3, 2)
-  },
   get inFreeBSDJail() {
     if (inFreeBSDJail !== null) return inFreeBSDJail
     if (exports.isFreeBSD && execSync('sysctl -n security.jail.jailed').toString() === '1\n') {

test/fixtures/tz-version.txt

@@ -1 +1 @@
-2024a
+2023c