build for 5.6.0 #185
Merged
build for 5.6.0 #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
and we are actually green! https://travis-ci.org/nodejs/readable-stream/builds/109629800 |
|
can I get a 👍 on this from anyone in @nodejs/streams so I can start work on v5.7.0? |
|
LGTM, but I'm not in @nodejs/streams (how can I join?) |
|
that is a very good question looks like @chrisdickinson or @rvagg would have to invite you |
|
Done, but I think if you click through to @nodejs/streams you can request membership at least. @calvinmetcalf could do with a hand around here I think! Thanks @mcollina. |
|
Thanks @rvagg! It's not clear how you join a WG for the docs. |
|
that's up to the WG to figure out, some are more open than others by nature |
|
@rvagg of course! :) But even that is not written anywhere. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.