-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add node >= 6 to package.json #362
Conversation
Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks! But why did my email change in the commit? Can my private email be removed from master, please? I would like to use the email set on the commit in my PR if possible. Thanks! |
I just hit the the "squash and merge button". You should probably remove your private email from Github. Which email do you want to use? I cannot easily see what you used in that commit. |
This is my commit: https://github.com/nodejs/readable-stream/commit/08f6c1162be23e0f2eb624a22cfe053241639f11.patch I'm not sure what you mean by remove it from github. My somethingdoug.com email is on github. |
I did not know what was your private email, and it was automatically used by Github when using the "squash" button. So, github knows your private email and tends to use it for these things. If you do not want it to appear in a commit, you should change your github configuration. |
Ah, I see. I will email github support and stop using github for the time being to see what is going on. Thanks for that info for what you did, I will pass that along! Anyway, hopefully that patch link works for you. Otherwise it's just the email listed on my github profile that I want to use 👍 |
I've just amended the commit and force-pushed. Please check. |
Looks good. Sorry for the trouble of what should have been a simple PR 😕 |
Hi ! I noticed that in 3.x
I added this to the
package.json
so automated tools that determine this requirement.