Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keyring: add 890C08DB8579162FEE0DF9DB8BEAB4DFCF555EF4 to keyring #24

Merged
merged 1 commit into from
Mar 23, 2023
Merged

keyring: add 890C08DB8579162FEE0DF9DB8BEAB4DFCF555EF4 to keyring #24

merged 1 commit into from
Mar 23, 2023

Conversation

BethGriggs
Copy link
Member

@BethGriggs BethGriggs commented Mar 22, 2023 •
edited
Loading

./cli.sh add 890C08DB8579162FEE0DF9DB8BEAB4DFCF555EF4

Refs: #21

@RafaelGSS's key was added by #16 but not added to the keychain. This PR adds it to the keyring via the CLI:

$ ./cli.sh add 890C08DB8579162FEE0DF9DB8BEAB4DFCF555EF4

After adding, I can verify the v19.4.0 signatures using the keyring:

$ GNUPGHOME=~/release-keys/gpg gpg --verify SHASUMS256.txt.sig SHASUMS256.txt  
gpg: Signature made Fri  6 Jan 13:15:00 2023 GMT
gpg:                using RSA key 890C08DB8579162FEE0DF9DB8BEAB4DFCF555EF4
gpg: Good signature from "RafaelGSS <rafael.nunu@hotmail.com>" [unknown]
...

@BethGriggs
keyring: add 890C08DB8579162FEE0DF9DB8BEAB4DFCF555EF4 to keyring
8126315 
`./cli.sh add 890C08DB8579162FEE0DF9DB8BEAB4DFCF555EF4`
@BethGriggs BethGriggs requested a review from RafaelGSS March 23, 2023 10:33
RafaelGSS
RafaelGSS approved these changes Mar 23, 2023
View reviewed changes
Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@BethGriggs BethGriggs merged commit ee32302 into nodejs:main Mar 23, 2023
@BethGriggs BethGriggs deleted the add-missing-key branch March 23, 2023 16:15
@ruyadorno ruyadorno mentioned this pull request Jun 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@richardlau richardlau richardlau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BethGriggs @richardlau @RafaelGSS