Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI Reliability 2022-07-27 #333

Open
16 tasks
github-actions bot opened this issue Jul 27, 2022 · 0 comments
Open
16 tasks

CI Reliability 2022-07-27 #333

github-actions bot opened this issue Jul 27, 2022 · 0 comments

Comments

@github-actions
Copy link

Failures in node-test-pull-request/45598 to node-test-pull-request/45695 that failed more than 2 PRs
(Generated with ncu-ci walk pr --stats=true --markdown /home/runner/work/reliability/reliability/results.md)

UTC Time RUNNING SUCCESS UNSTABLE ABORTED FAILURE Green Rate
2022-07-27 00:17 0 7 36 2 55 7.14%

JSTest Failure

Reason pummel/test-http-upload-timeout
Type JS_TEST_FAILURE
Failed PR 12 (nodejs/node#43902, nodejs/node#43957, nodejs/node#43948, nodejs/node#43951, nodejs/node#43656, nodejs/node#43866, nodejs/node#43967, nodejs/node#43887, nodejs/node#43965, nodejs/node#43878, nodejs/node#43911, nodejs/node#43779)
Appeared test-macstadium-macos11.0-arm64-3, test-digitalocean-ubuntu1804_sharedlibs_container-x64-3, test-digitalocean-fedora32-x64-1, test-softlayer-alpine312_container-x64-1, test-orka-macos10.15-x64-2, test-softlayer-alpine311_container-x64-1, test-joyent-ubuntu1804-x64-1, test-joyent-smartos20-x64-4, test-equinix-ubuntu2004_container-armv7l-2, test-nearform-macos11.0-arm64-1, test-digitalocean-alpine311_container-x64-1, test-digitalocean-ubuntu1804_sharedlibs_container-x64-8, test-azure_msft-win10_vs2019-x64-1, test-rackspace-win2012r2_vs2019-x64-4
First CI https://ci.nodejs.org/job/node-test-pull-request/45606/
Last CI https://ci.nodejs.org/job/node-test-pull-request/45645/
Example 
not ok 3335 pummel/test-http-upload-timeout
  ---
  duration_ms: 5.975
  severity: fail
  exitcode: 1
  stack: |-
    /Users/iojs/build/workspace/node-test-commit-osx-arm/nodes/osx11/test/pummel/test-http-upload-timeout.js:34
        throw new Error('Unexpected timeout');
        ^
    
    Error: Unexpected timeout
        at Socket.<anonymous> (/Users/iojs/build/workspace/node-test-commit-osx-arm/nodes/osx11/test/pummel/test-http-upload-timeout.js:34:11)
        at Socket.emit (node:events:525:35)
        at Socket._onTimeout (node:net:522:8)
        at listOnTimeout (node:internal/timers:564:17)
        at process.processTimers (node:internal/timers:507:7)
    
    Node.js v19.0.0-pre
  ...
Reason sequential/test-gc-http-client-onerror
Type JS_TEST_FAILURE
Failed PR 6 (nodejs/node#43866, nodejs/node#43787, nodejs/node#43958, nodejs/node#43086, nodejs/node#43935, nodejs/node#43877)
Appeared test-equinix-ubuntu2004_container-armv7l-1, test-equinix-debian10_container-armv7l-2, test-equinix-ubuntu2004_container-armv7l-2, test-equinix-ubuntu2004_container-arm64-2
First CI https://ci.nodejs.org/job/node-test-pull-request/45618/
Last CI https://ci.nodejs.org/job/node-test-pull-request/45648/
Example 
not ok 3472 sequential/test-gc-http-client-onerror
  ---
  duration_ms: 1.715
  severity: fail
  exitcode: 1
  stack: |-
    done/collected/total: 160/0/640
    done/collected/total: 320/160/640
    done/collected/total: 480/256/640
    done/collected/total: 638/320/640
    done/collected/total: 640/480/640
    done/collected/total: 640/638/640
    done/collected/total: 640/640/640
    node:_http_server:493
        if (connections[i].socket._httpMessage && !connections[i].socket._httpMessage.finished) {
                                  ^
    
    TypeError: Cannot read properties of null (reading '_httpMessage')
        at Server.closeIdleConnections (node:_http_server:493:31)
        at Server.close (node:_http_server:476:8)
        at Immediate.status (/home/iojs/build/workspace/node-test-binary-armv7l/test/sequential/test-gc-http-client-onerror.js:65:14)
        at process.processImmediate (node:internal/timers:471:21)
    
    Node.js v19.0.0-pre
  ...
Reason sequential/test-gc-http-client
Type JS_TEST_FAILURE
Failed PR 5 (nodejs/node#43866, nodejs/node#43747, nodejs/node#43951, nodejs/node#43887, nodejs/node#43787)
Appeared test-equinix-debian10_container-armv7l-2, test-equinix-ubuntu2004_container-armv7l-2, test-equinix-ubuntu2004_container-armv7l-1
First CI https://ci.nodejs.org/job/node-test-pull-request/45602/
Last CI https://ci.nodejs.org/job/node-test-pull-request/45646/
Example 
not ok 3430 sequential/test-gc-http-client
  ---
  duration_ms: 1.717
  severity: fail
  exitcode: 1
  stack: |-
    done/collected/total: 160/0/640
    done/collected/total: 320/160/640
    done/collected/total: 480/256/640
    done/collected/total: 630/320/640
    done/collected/total: 640/480/640
    done/collected/total: 640/630/640
    done/collected/total: 640/640/640
    node:_http_server:493
        if (connections[i].socket._httpMessage && !connections[i].socket._httpMessage.finished) {
                                  ^
    
    TypeError: Cannot read properties of null (reading '_httpMessage')
        at Server.closeIdleConnections (node:_http_server:493:31)
        at Server.close (node:_http_server:476:8)
        at Immediate.status (/home/iojs/build/workspace/node-test-binary-armv7l/test/sequential/test-gc-http-client.js:60:14)
        at process.processImmediate (node:internal/timers:471:21)
    
    Node.js v19.0.0-pre
  ...
Reason parallel/test-net-connect-memleak
Type JS_TEST_FAILURE
Failed PR 3 (nodejs/node#43760, nodejs/node#43993, nodejs/node#43629)
Appeared test-azure_msft-win2016_vs2017-x64-5, test-rackspace-win2012r2_vs2015-x64-2
First CI https://ci.nodejs.org/job/node-test-pull-request/45675/
Last CI https://ci.nodejs.org/job/node-test-pull-request/45685/
Example 
not ok 436 parallel/test-net-connect-memleak
  ---
  duration_ms: 0.260
  severity: fail
  exitcode: 1
  stack: |-
    Mismatched noop function calls. Expected exactly 1, actual 0.
        at Proxy.mustCall (C:\workspace\node-test-binary-windows-js-suites\node\test\common\index.js:338:10)
        at Object.<anonymous> (C:\workspace\node-test-binary-windows-js-suites\node\test\parallel\test-net-connect-memleak.js:33:40)
        at Module._compile (internal/modules/cjs/loader.js:1085:14)
        at Object.Module._extensions..js (internal/modules/cjs/loader.js:1114:10)
        at Module.load (internal/modules/cjs/loader.js:950:32)
        at Function.Module._load (internal/modules/cjs/loader.js:790:12)
        at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:75:12)
        at internal/main/run_main_module.js:17:47
  ...
Reason parallel/test-vm-break-on-sigint
Type JS_TEST_FAILURE
Failed PR 3 (nodejs/node#43883, nodejs/node#43935, nodejs/node#43902)
Appeared test-digitalocean-ubuntu1804_sharedlibs_container-x64-3, test-digitalocean-ubuntu1804_sharedlibs_container-x64-6, test-digitalocean-ubuntu1804_sharedlibs_container-x64-7, test-digitalocean-alpine311_container-x64-1, test-digitalocean-alpine312_container-x64-1, test-digitalocean-ubi81_container-x64-1, test-digitalocean-ubuntu1804_sharedlibs_container-x64-9, test-digitalocean-ubuntu1804_sharedlibs_container-x64-1, test-digitalocean-ubuntu1804_sharedlibs_container-x64-5
First CI https://ci.nodejs.org/job/node-test-pull-request/45631/
Last CI https://ci.nodejs.org/job/node-test-pull-request/45684/
Example 
not ok 3148 parallel/test-vm-break-on-sigint
  ---
  duration_ms: 120.127
  severity: fail
  exitcode: -15
  stack: |-
    timeout
  ...
Reason node-api/test_threadsafe_function/test
Type JS_TEST_FAILURE
Failed PR 2 (nodejs/node#43086, nodejs/node#43938)
Appeared test-equinix-ubuntu2004_container-armv7l-2, test-equinix-ubuntu2004_container-armv7l-1
First CI https://ci.nodejs.org/job/node-test-pull-request/45604/
Last CI https://ci.nodejs.org/job/node-test-pull-request/45653/
Example 
not ok 3491 node-api/test_threadsafe_function/test
  ---
  duration_ms: 360.25
  severity: fail
  exitcode: -15
  stack: |-
    timeout
  ...
Reason parallel/test-vm-timeout-escape-promise-module
Type JS_TEST_FAILURE
Failed PR 2 (nodejs/node#43866, nodejs/node#43887)
Appeared test-osuosl-rhel8-ppc64_le-2, test-digitalocean-freebsd12-x64-2
First CI https://ci.nodejs.org/job/node-test-pull-request/45602/
Last CI https://ci.nodejs.org/job/node-test-pull-request/45628/
Example 
not ok 2975 parallel/test-vm-timeout-escape-promise-module
  ---
  duration_ms: 0.321
  severity: fail
  exitcode: 1
  stack: |-
    (node:482405) ExperimentalWarning: VM Modules is an experimental feature. This feature could change at any time
    (Use `node --trace-warnings ...` to show where the warning was created)
    /home/iojs/build/workspace/node-test-commit-plinux/nodes/rhel8-ppc64le/test/parallel/test-vm-timeout-escape-promise-module.js:22
          throw new Error(
                ^
    
    Error: escaped timeout at 100 milliseconds!
        at loop (/home/iojs/build/workspace/node-test-commit-plinux/nodes/rhel8-ppc64le/test/parallel/test-vm-timeout-escape-promise-module.js:22:13)
        at vm:module(0):1:39
        at SourceTextModule.evaluate (node:internal/vm/module:226:23)
        at assert.rejects.code (/home/iojs/build/workspace/node-test-commit-plinux/nodes/rhel8-ppc64le/test/parallel/test-vm-timeout-escape-promise-module.js:38:16)
        at process.processTicksAndRejections (node:interna...
Reason parallel/test-worker-fshandles-error-on-termination
Type JS_TEST_FAILURE
Failed PR 2 (nodejs/node#43883, nodejs/node#43902)
Appeared test-digitalocean-ubuntu1804_sharedlibs_container-x64-6, test-digitalocean-alpine311_container-x64-1, test-digitalocean-alpine312_container-x64-1, test-digitalocean-ubi81_container-x64-1, test-digitalocean-ubuntu1804_sharedlibs_container-x64-9, test-digitalocean-ubuntu1804_sharedlibs_container-x64-1, test-digitalocean-ubuntu1804_sharedlibs_container-x64-7, test-digitalocean-ubuntu1804_sharedlibs_container-x64-5
First CI https://ci.nodejs.org/job/node-test-pull-request/45631/
Last CI https://ci.nodejs.org/job/node-test-pull-request/45673/
Example 
not ok 3024 parallel/test-worker-fshandles-error-on-termination
  ---
  duration_ms: 120.123
  severity: fail
  exitcode: -15
  stack: |-
    timeout
  ...
Reason parallel/test-worker-fshandles-open-close-on-termination
Type JS_TEST_FAILURE
Failed PR 2 (nodejs/node#43883, nodejs/node#43902)
Appeared test-digitalocean-ubuntu1804_sharedlibs_container-x64-6, test-digitalocean-alpine311_container-x64-1, test-digitalocean-alpine312_container-x64-1, test-digitalocean-ubi81_container-x64-1, test-digitalocean-ubuntu1804_sharedlibs_container-x64-9, test-digitalocean-ubuntu1804_sharedlibs_container-x64-1, test-digitalocean-ubuntu1804_sharedlibs_container-x64-7, test-digitalocean-ubuntu1804_sharedlibs_container-x64-5
First CI https://ci.nodejs.org/job/node-test-pull-request/45631/
Last CI https://ci.nodejs.org/job/node-test-pull-request/45673/
Example 
not ok 3026 parallel/test-worker-fshandles-open-close-on-termination
  ---
  duration_ms: 120.64
  severity: fail
  exitcode: -15
  stack: |-
    timeout
  ...
Reason pummel/test-fs-largefile
Type JS_TEST_FAILURE
Failed PR 2 (nodejs/node#43787, nodejs/node#43878)
Appeared test-rackspace-win2012r2_vs2019-x64-4
First CI https://ci.nodejs.org/job/node-test-pull-request/45622/
Last CI https://ci.nodejs.org/job/node-test-pull-request/45623/
Example 
not ok 825 pummel/test-fs-largefile
  ---
  duration_ms: 0.939
  severity: fail
  exitcode: 1
  stack: |-
    Can't clean tmpdir: C:\workspace\node-test-binary-windows-js-suites\node\test\.tmp.826
    Files blocking: [ 'large.txt' ]
    
    node:internal/fs/utils:348
        throw err;
        ^
    
    Error: ENOSPC: no space left on device, ftruncate
        at Object.ftruncateSync (node:fs:1136:3)
        at Object.<anonymous> (C:\workspace\node-test-binary-windows-js-suites\node\test\pummel\test-fs-largefile.js:37:4)
        at Module._compile (node:internal/modules/cjs/loader:1120:14)
        at Module._extensions..js (node:internal/modules/cjs/loader:1174:10)
        at Module.load (node:internal/modules/cjs/loader:998:32)
        at Module._load (node:internal/modules/cjs/loader:839:12)
        at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12)
        at node:internal/main/run_main_module:17:47 {
      errno: -4055,
      syscall: 'ftruncate',
      code: 'ENOSPC'
...
Reason sequential/test-worker-prof
Type JS_TEST_FAILURE
Failed PR 2 (nodejs/node#43967, nodejs/node#43760)
Appeared test-digitalocean-ubuntu1804_sharedlibs_container-x64-3, test-equinix-ubuntu1804_sharedlibs_container-arm64-3
First CI https://ci.nodejs.org/job/node-test-pull-request/45625/
Last CI https://ci.nodejs.org/job/node-test-pull-request/45675/
Example 
not ok 3231 sequential/test-worker-prof
  ---
  duration_ms: 30.801
  severity: fail
  exitcode: 1
  stack: |-
    assert.js:118
      throw new AssertionError(obj);
      ^
    
    AssertionError [ERR_ASSERTION]: child exited with signal: {
      error: Error: spawnSync /home/iojs/build/workspace/node-test-commit-linux-containered/out/Debug/node ETIMEDOUT
          at Object.spawnSync (internal/child_process.js:1107:20)
          at spawnSync (child_process.js:776:24)
          at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-linux-containered/test/sequential/test-worker-prof.js:52:23)
          at Module._compile (internal/modules/cjs/loader.js:1085:14)
          at Object.Module._extensions..js (internal/modules/cjs/loader.js:1114:10)
          at Module.load (internal/modules/cjs/loader.js:950:32)
          at Function.Module._load (internal/modules/cjs/loader.js:790:12)
          at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:75:12)
          at internal/m...

Jenkins Failure

Reason Backing channel 'JNLP4-connect connection from ... is disconnected.
Type JENKINS_FAILURE
Failed PR 13 (nodejs/node#43086, nodejs/node#43949, nodejs/node#43883, nodejs/node#43877, nodejs/node#43787, nodejs/node#43903, nodejs/node#43967, nodejs/node#43979, nodejs/node#43977, nodejs/node#43921, nodejs/node#43990, nodejs/node#43993, nodejs/node#44001)
Appeared test-equinix-ubuntu2004_container-armv7l-2, test-digitalocean-freebsd12-x64-2, test-digitalocean-freebsd12-x64-1, test-equinix-ubuntu2004_container-armv7l-1
First CI https://ci.nodejs.org/job/node-test-pull-request/45626/
Last CI https://ci.nodejs.org/job/node-test-pull-request/45693/
Example 
java.io.IOException: Backing channel 'JNLP4-connect connection from 145.40.99.31/145.40.99.31:42908' is disconnected.
	at hudson.remoting.RemoteInvocationHandler.channelOrFail(RemoteInvocationHandler.java:216)
	at hudson.remoting.RemoteInvocationHandler.invoke(RemoteInvocationHandler.java:286)
	at com.sun.proxy.$Proxy79.isAlive(Unknown Source)
	at hudson.Launcher$RemoteLauncher$ProcImpl.isAlive(Launcher.java:1213)
	at hudson.Launcher$RemoteLauncher$ProcImpl.join(Launcher.java:1205)

Build Failure

Reason ERROR: Step ?Publish JUnit test result report? failed: No test report files were found. Configuration error?
Type BUILD_FAILURE
Failed PR 4 (nodejs/node#43903, nodejs/node#43889, nodejs/node#43779, nodejs/node#43629)
Appeared test-equinix-debian10_container-armv7l-2, test-equinix-ubuntu2004_container-armv7l-1, test-equinix-debian10_container-armv7l-1, test-equinix-ubuntu2004_container-armv7l-2, test-joyent-smartos20-x64-4
First CI https://ci.nodejs.org/job/node-test-pull-request/45598/
Last CI https://ci.nodejs.org/job/node-test-pull-request/45681/
Example 
ERROR: Step ?Publish JUnit test result report? failed: No test report files were found. Configuration error?
[PostBuildScript] - [INFO] Executing post build scripts.
[node-test-binary-armv7l] $ /bin/bash -ex /tmp/jenkins14830112737259348563.sh
+ '[' -d .git ']'
+ git clean -fdx
Reason ERROR: Step ‘Publish JUnit test result report’ failed: no workspace for ...
Type BUILD_FAILURE
Failed PR 3 (nodejs/node#43086, nodejs/node#43866, nodejs/node#43993)
Appeared test-nearform-macos11.0-arm64-1, test-digitalocean-freebsd12-x64-2
First CI https://ci.nodejs.org/job/node-test-pull-request/45604/
Last CI https://ci.nodejs.org/job/node-test-pull-request/45678/
Example 
ERROR: Step ‘Publish JUnit test result report’ failed: no workspace for node-test-commit-osx-arm/nodes=osx11 #6793
Collecting metadata...
Metadata collection done.
Notifying upstream projects of job completion
Finished: FAILURE
Reason ERROR: Build step failed with exception
Type BUILD_FAILURE
Failed PR 2 (nodejs/node#43492, nodejs/node#43521)
Appeared test-equinix-ubuntu2004_container-armv7l-2
First CI https://ci.nodejs.org/job/node-test-pull-request/45688/
Last CI https://ci.nodejs.org/job/node-test-pull-request/45689/
Example 
ERROR: Build step failed with exception
java.lang.NullPointerException: no workspace from node hudson.slaves.DumbSlave[test-equinix-ubuntu2004_container-armv7l-2] which is computer hudson.slaves.SlaveComputer@2ad6001 and has channel null
	at hudson.tasks.CommandInterpreter.perform(CommandInterpreter.java:113)
	at hudson.tasks.CommandInterpreter.perform(CommandInterpreter.java:91)
	at org.jenkinsci.plugins.postbuildscript.processor.Processor.processBuildSteps(Processor.java:180)
	at org.jenkinsci.plugins.postbuildscript.processor.Processor.processScripts(Processor.java:91)

undefined

Reason Unknown
Type undefined
Failed PR 25 (nodejs/node#43903, nodejs/node#43902, nodejs/node#43747, nodejs/node#43951, nodejs/node#43866, nodejs/node#43656, nodejs/node#43878, nodejs/node#43086, nodejs/node#43887, nodejs/node#43883, nodejs/node#43935, nodejs/node#43779, nodejs/node#43787, nodejs/node#43877, nodejs/node#43967, nodejs/node#43976, nodejs/node#43921, nodejs/node#43760, nodejs/node#43990, nodejs/node#43993, nodejs/node#43629, nodejs/node#43977, nodejs/node#43492, nodejs/node#43521, nodejs/node#44001)
Appeared test-equinix-debian10_container-armv7l-1, test-nearform_arm-win10_vs2019-arm64-1
First CI https://ci.nodejs.org/job/node-test-pull-request/45598/
Last CI https://ci.nodejs.org/job/node-test-pull-request/45693/
Example 
Unknown

Progress

  • pummel/test-http-upload-timeout (12)
  • sequential/test-gc-http-client-onerror (6)
  • sequential/test-gc-http-client (5)
  • parallel/test-net-connect-memleak (3)
  • parallel/test-vm-break-on-sigint (3)
  • node-api/test_threadsafe_function/test (2)
  • parallel/test-vm-timeout-escape-promise-module (2)
  • parallel/test-worker-fshandles-error-on-termination (2)
  • parallel/test-worker-fshandles-open-close-on-termination (2)
  • pummel/test-fs-largefile (2)
  • sequential/test-worker-prof (2)
  • Backing channel 'JNLP4-connect connection from ... is disconnected. (13)
  • ERROR: Step ?Publish JUnit test result report? failed: No test report files were found. Configuration error? (4)
  • ERROR: Step ‘Publish JUnit test result report’ failed: no workspace for ... (3)
  • ERROR: Build step failed with exception (2)
  • Unknown (25)
@joyeecheung joyeecheung mentioned this issue Aug 29, 2022
Closed
joyeecheung added a commit to nodejs/node that referenced this issue Aug 31, 2022
@joyeecheung
test: make the vm timeout escape tests more lenient
2d22820 
Previously the tests required that Node.js finish the initialization
of the watchdog thread and fires the timeout within 100ms, which
can be difficult on certain systems under load. This patch
relaxes the requirement to 2000ms. If there is a bug and the
timeout can actually be escaped, raising the timeout to 2000ms
would not make a difference anyway.

PR-URL: #44433
Refs: nodejs/reliability#333
Refs: nodejs/reliability#361
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
joyeecheung added a commit to joyeecheung/node that referenced this issue Sep 1, 2022
@joyeecheung
test: make the vm timeout escape tests more lenient
12f7635 
Previously the tests required that Node.js finish the initialization
of the watchdog thread and fires the timeout within 100ms, which
can be difficult on certain systems under load. This patch
relaxes the requirement to 2000ms. If there is a bug and the
timeout can actually be escaped, raising the timeout to 2000ms
would not make a difference anyway.

PR-URL: nodejs#44433
Refs: nodejs/reliability#333
Refs: nodejs/reliability#361
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
joyeecheung added a commit to joyeecheung/node that referenced this issue Sep 1, 2022
@joyeecheung
test: make the vm timeout escape tests more lenient
abc3f87 
Previously the tests required that Node.js finish the initialization
of the watchdog thread and fires the timeout within 100ms, which
can be difficult on certain systems under load. This patch
relaxes the requirement to 2000ms. If there is a bug and the
timeout can actually be escaped, raising the timeout to 2000ms
would not make a difference anyway.

PR-URL: nodejs#44433
Refs: nodejs/reliability#333
Refs: nodejs/reliability#361
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
RafaelGSS pushed a commit to nodejs/node that referenced this issue Sep 5, 2022
@joyeecheung @RafaelGSS
test: make the vm timeout escape tests more lenient
aeaea85 
Previously the tests required that Node.js finish the initialization
of the watchdog thread and fires the timeout within 100ms, which
can be difficult on certain systems under load. This patch
relaxes the requirement to 2000ms. If there is a bug and the
timeout can actually be escaped, raising the timeout to 2000ms
would not make a difference anyway.

PR-URL: #44433
Refs: nodejs/reliability#333
Refs: nodejs/reliability#361
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
joyeecheung added a commit to joyeecheung/node that referenced this issue Sep 6, 2022
@joyeecheung
test: make the vm timeout escape tests more lenient
5dd57ef 
Previously the tests required that Node.js finish the initialization
of the watchdog thread and fires the timeout within 100ms, which
can be difficult on certain systems under load. This patch
relaxes the requirement to 2000ms. If there is a bug and the
timeout can actually be escaped, raising the timeout to 2000ms
would not make a difference anyway.

PR-URL: nodejs#44433
Refs: nodejs/reliability#333
Refs: nodejs/reliability#361
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
RafaelGSS pushed a commit to nodejs/node that referenced this issue Sep 6, 2022
@joyeecheung @RafaelGSS
test: make the vm timeout escape tests more lenient
e884628 
Previously the tests required that Node.js finish the initialization
of the watchdog thread and fires the timeout within 100ms, which
can be difficult on certain systems under load. This patch
relaxes the requirement to 2000ms. If there is a bug and the
timeout can actually be escaped, raising the timeout to 2000ms
would not make a difference anyway.

PR-URL: #44433
Refs: nodejs/reliability#333
Refs: nodejs/reliability#361
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
RafaelGSS pushed a commit to nodejs/node that referenced this issue Sep 7, 2022
@joyeecheung @RafaelGSS
test: make the vm timeout escape tests more lenient
0af15c7 
Previously the tests required that Node.js finish the initialization
of the watchdog thread and fires the timeout within 100ms, which
can be difficult on certain systems under load. This patch
relaxes the requirement to 2000ms. If there is a bug and the
timeout can actually be escaped, raising the timeout to 2000ms
would not make a difference anyway.

PR-URL: #44433
Refs: nodejs/reliability#333
Refs: nodejs/reliability#361
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Fyko pushed a commit to Fyko/node that referenced this issue Sep 15, 2022
@joyeecheung @Fyko
test: make the vm timeout escape tests more lenient
15cdf39 
Previously the tests required that Node.js finish the initialization
of the watchdog thread and fires the timeout within 100ms, which
can be difficult on certain systems under load. This patch
relaxes the requirement to 2000ms. If there is a bug and the
timeout can actually be escaped, raising the timeout to 2000ms
would not make a difference anyway.

PR-URL: nodejs#44433
Refs: nodejs/reliability#333
Refs: nodejs/reliability#361
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
targos pushed a commit to nodejs/node that referenced this issue Sep 16, 2022
@joyeecheung @targos
test: make the vm timeout escape tests more lenient
965a5b8 
Previously the tests required that Node.js finish the initialization
of the watchdog thread and fires the timeout within 100ms, which
can be difficult on certain systems under load. This patch
relaxes the requirement to 2000ms. If there is a bug and the
timeout can actually be escaped, raising the timeout to 2000ms
would not make a difference anyway.

PR-URL: #44433
Refs: nodejs/reliability#333
Refs: nodejs/reliability#361
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
juanarbol pushed a commit to nodejs/node that referenced this issue Oct 10, 2022
@joyeecheung @juanarbol
test: make the vm timeout escape tests more lenient
3a36bda 
Previously the tests required that Node.js finish the initialization
of the watchdog thread and fires the timeout within 100ms, which
can be difficult on certain systems under load. This patch
relaxes the requirement to 2000ms. If there is a bug and the
timeout can actually be escaped, raising the timeout to 2000ms
would not make a difference anyway.

PR-URL: #44433
Refs: nodejs/reliability#333
Refs: nodejs/reliability#361
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
juanarbol pushed a commit to nodejs/node that referenced this issue Oct 11, 2022
@joyeecheung @juanarbol
test: make the vm timeout escape tests more lenient
c3429ab 
Previously the tests required that Node.js finish the initialization
of the watchdog thread and fires the timeout within 100ms, which
can be difficult on certain systems under load. This patch
relaxes the requirement to 2000ms. If there is a bug and the
timeout can actually be escaped, raising the timeout to 2000ms
would not make a difference anyway.

PR-URL: #44433
Refs: nodejs/reliability#333
Refs: nodejs/reliability#361
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
guangwong pushed a commit to noslate-project/node that referenced this issue Jan 3, 2023
@joyeecheung @guangwong
test: make the vm timeout escape tests more lenient
1196343 
Previously the tests required that Node.js finish the initialization
of the watchdog thread and fires the timeout within 100ms, which
can be difficult on certain systems under load. This patch
relaxes the requirement to 2000ms. If there is a bug and the
timeout can actually be escaped, raising the timeout to 2000ms
would not make a difference anyway.

PR-URL: nodejs/node#44433
Refs: nodejs/reliability#333
Refs: nodejs/reliability#361
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
guangwong pushed a commit to noslate-project/node that referenced this issue Jan 3, 2023
@joyeecheung @guangwong
test: make the vm timeout escape tests more lenient
2802d1f 
Previously the tests required that Node.js finish the initialization
of the watchdog thread and fires the timeout within 100ms, which
can be difficult on certain systems under load. This patch
relaxes the requirement to 2000ms. If there is a bug and the
timeout can actually be escaped, raising the timeout to 2000ms
would not make a difference anyway.

PR-URL: nodejs/node#44433
Refs: nodejs/reliability#333
Refs: nodejs/reliability#361
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
0 participants