Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

workflow: add update core/npm indexes #865

Merged
merged 1 commit into from
Feb 2, 2023
Merged

workflow: add update core/npm indexes #865

merged 1 commit into from
Feb 2, 2023

Conversation

RafaelGSS
Copy link
Member

Following up #864

@RafaelGSS
Copy link
Member Author

It's still a draft because I need to test it locally.

@RafaelGSS RafaelGSS mentioned this pull request Jan 23, 2023
Merged
@RafaelGSS RafaelGSS marked this pull request as ready for review January 28, 2023 12:25
@RafaelGSS RafaelGSS requested a review from a team January 28, 2023 13:24
@mhdawson
Copy link
Member

Thanks for putting this together. Looks good so far.

@RafaelGSS
Copy link
Member Author

@mhdawson can I get your approval?

@fraxken
Copy link
Member

fraxken commented Feb 2, 2023

@RafaelGSS Where are those two update- npm scripts? In package.json there is only create- scripts.

mhdawson
mhdawson approved these changes Feb 2, 2023
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RafaelGSS
Copy link
Member Author

@RafaelGSS Where are those two update- npm scripts? In package.json there is only create- scripts.

Fixed. Forgot about it.

@RafaelGSS RafaelGSS merged commit de1ce72 into nodejs:main Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@UlisesGascon UlisesGascon UlisesGascon approved these changes

Assignees
No one assigned
Labels
security-wg-agenda
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RafaelGSS @mhdawson @fraxken @UlisesGascon