Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add tests #34

Merged
merged 4 commits into from
Jul 18, 2022
Merged

add tests #34

merged 4 commits into from
Jul 18, 2022

Conversation

MoLow
Copy link
Member

@MoLow MoLow commented Jul 18, 2022 •
edited
Loading

fixes: #33

cclauss
cclauss reviewed Jul 18, 2022
View reviewed changes
test/_prepare_outputs.py Outdated Show resolved Hide resolved
cclauss
cclauss reviewed Jul 18, 2022
View reviewed changes
test/test_outputs.py Outdated Show resolved Hide resolved
@MoLow MoLow marked this pull request as draft July 18, 2022 12:46
@MoLow MoLow mentioned this pull request Jul 18, 2022
Merged
@MoLow MoLow marked this pull request as ready for review July 18, 2022 13:30
@MoLow MoLow requested a review from cclauss July 18, 2022 13:30
@MoLow
Copy link
Member Author

MoLow commented Jul 18, 2022

I copied the change from #34 to make sure tests pass

cclauss
cclauss reviewed Jul 18, 2022
View reviewed changes
test/_common.py Outdated Show resolved Hide resolved
@MoLow @cclauss
Update test/_common.py
068f324 
Co-authored-by: Christian Clauss <cclauss@me.com>
@cclauss cclauss merged commit 4695632 into nodejs:main Jul 18, 2022
@MoLow MoLow deleted the add-tests branch July 18, 2022 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Need automated tests
3 participants
@MoLow @cclauss @richardlau