TODO

nodejs · Aug 16, 2020 · 6b01995 · 6b01995
1 parent 9ac9583
commit 6b01995
Showing 1 changed file with 9 additions and 4 deletions.
diff --git a/lib/client.js b/lib/client.js
@@ -565,10 +565,14 @@ class Parser extends HTTPParser {
     // not from start.
 
     const ret = request.onBody(chunk, offset, length)
-    if (ret == null && this.read > client[kMaxAbortedPayload]) {
-      client[kQueue][client[kRunningIdx]++] = null
-      this.statusCode = null
-      util.destroy(socket, new InformationalError('max aborted payload'))
+    if (ret == null) {
+      // TODO: Stop more requests from being scheduled, i.e. busy=true
+      // until requests has either completed or socket is destroyed.
+      if (this.read > client[kMaxAbortedPayload]) {
+        client[kQueue][client[kRunningIdx]++] = null
+        this.statusCode = null
+        util.destroy(socket, new InformationalError('max aborted payload'))
+      }
     } else if (ret === false) {
       socket.pause()
     }
@@ -585,6 +589,7 @@ class Parser extends HTTPParser {
     assert(statusCode >= 100)
 
     if (upgrade) {
+      // TODO: When, how and why does this happen?
       assert(statusCode < 300 || request.method === 'CONNECT')
       return
     }