refactor: separate writeH1 and writeH2

nodejs · Feb 25, 2024 · b23d1f7 · b23d1f7
1 parent 3379548
commit b23d1f7
Showing 1 changed file with 9 additions and 3 deletions.
diff --git a/lib/dispatcher/client.js b/lib/dispatcher/client.js
@@ -1399,10 +1399,15 @@ function shouldSendContentLength (method) {
 
 function write (client, request) {
   if (client[kHTTPConnVersion] === 'h2') {
-    writeH2(client, client[kHTTP2Session], request)
-    return
+    // TODO (fix): Why does this not return the value
+    // from writeH2.
+    writeH2(client, request)
+  } else {
+    return writeH1(client, request)
   }
+}
 
+function writeH1 (client, request) {
   const { method, path, host, upgrade, blocking, reset } = request
 
   let { body, headers, contentLength } = request
@@ -1580,7 +1585,8 @@ function write (client, request) {
   return true
 }
 
-function writeH2 (client, session, request) {
+function writeH2 (client, request) {
+  const session = client[kHTTP2Session]
   const { body, method, path, host, upgrade, expectContinue, signal, headers: reqHeaders } = request
 
   let headers