apply suggestions from code review

nodejs · Apr 12, 2024 · c76954a · c76954a
1 parent a16334d
commit c76954a
Showing 1 changed file with 5 additions and 8 deletions.
diff --git a/benchmarks/fetch/isomorphic-encode.mjs b/benchmarks/fetch/isomorphic-encode.mjs
@@ -28,10 +28,6 @@ function isomorphicEncode1 (input) {
   return input
 }
 
-/**
- * @see https://infra.spec.whatwg.org/#isomorphic-encode
- * @param {string} input
- */
 function isomorphicEncode2 (input) {
   // 1. Assert: input contains no code points greater than U+00FF.
   if (invalidIsomorphicEncodeValueRegex.test(input)) {
@@ -44,12 +40,13 @@ function isomorphicEncode2 (input) {
 }
 
 const settings = {
-  small: `${generateAsciiString(10)}`,
-  middle: `${generateAsciiString(30)}`,
-  long: `${generateAsciiString(70)}`
+  small: 10,
+  middle: 30,
+  long: 70
 }
 
-for (const [runName, value] of Object.entries(settings)) {
+for (const [runName, length] of Object.entries(settings)) {
+  const value = generateAsciiString(length)
   [
     { name: `${runName} (valid)`, value },
     {