perf: avoid calling into destroyMaybe

nodejs · May 3, 2020 · ffcb3dc · ffcb3dc
1 parent 5bd60c2
commit ffcb3dc
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/lib/client.js b/lib/client.js
@@ -270,7 +270,9 @@ class Client extends EventEmitter {
           headers: parseHeaders(headers),
           body: this[kLastBody]
         })
-        destroyMaybe(this)
+        if (this.closed) {
+          destroyMaybe(this)
+        }
         return skipBody
       }
 
@@ -284,7 +286,9 @@ class Client extends EventEmitter {
         if (body !== null) {
           body.push(null)
         }
-        destroyMaybe(this)
+        if (this.closed) {
+          destroyMaybe(this)
+        }
       }
     }
     this[kResetParser]()
@@ -428,7 +432,6 @@ module.exports = Client
 
 function destroyMaybe (client) {
   if (
-    client.closed &&
     !client[kLastBody] &&
     client[kQueue].length() === 0 &&
     client[kInflight].length === 0