-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cryptic error message for already aborted signals #2242
Comments
the error comes from Line 109 in 68e2275
|
I guess firefox and Deno's behavior is also right. reason why you get a DOMException when undefined is passed is b/c: |
it was the correct behavior before a spec change that made requests abort with the signal's reason rather than the standard error from abortsignals |
Undici have the most crypting error message when sending in an already aborted signal.
example:
undici:
Chrome:
Safari:
Firefox & Deno:
i tough i sent in something really wrong type when i was calling fetch when i received a TypeError.
but it's of a correct "type".
{ signal: "foo" }
is an TypeError and a invalid argument.The text was updated successfully, but these errors were encountered: