-
Notifications
You must be signed in to change notification settings - Fork 550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: readable.setEncoding #1129
Conversation
@koh110 Would you mind fixing tests? |
Codecov Report
@@ Coverage Diff @@
## main #1129 +/- ##
==========================================
+ Coverage 94.25% 96.40% +2.14%
==========================================
Files 40 30 -10
Lines 3815 2501 -1314
==========================================
- Hits 3596 2411 -1185
+ Misses 219 90 -129
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Fixing this is very complicated unfortunately... :/ |
63eab1d
to
47eb207
Compare
Fixes: #1125 (comment)