types: Align RequestInit type with lib.dom.ts type
#1196
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suneettipirneni
changed the title
RequestInit type with lib.dom.ts types
suneettipirneni
changed the title
RequestInit type with lib.dom.ts typesRequestInit type with lib.dom.ts type
Codecov Report
@@ Coverage Diff @@
## main #1196 +/- ##
=======================================
Coverage 93.73% 93.73%
=======================================
Files 43 43
Lines 4023 4023
=======================================
Hits 3771 3771
Misses 252 252 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relates to...
#1172
Rationale
Types for
RequestInitshould be fully compatible with typescript dom types.Changes
Adds all properties to
RequestInitthat were missing based on the typescript dom types. This adjusts theHeaderssubtype to also follow the typescript definitions.Features
N/A
Bug Fixes
closes #1172
Breaking Changes and Deprecations
N/A
Status
KEY: S = Skipped, x = complete