Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: port client-connect, client-dispatch, client-errors test to node:test #2591

Merged
merged 11 commits into from
Jan 16, 2024
Merged

feat: port client-connect, client-dispatch, client-errors test to node:test #2591

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
00c7cd2
`client-connect`
sosukesuzuki Jan 3, 2024
4f4bfb1
`client-dispatch`
sosukesuzuki Jan 3, 2024
74d6d7e
`client-errors`
sosukesuzuki Jan 4, 2024
c643b85
Use `done` instead of `t.end`
sosukesuzuki Jan 4, 2024
5e1d701
Fix `t.after`
sosukesuzuki Jan 5, 2024
7aaff7a
Update `return client.close()`
sosukesuzuki Jan 6, 2024
b36ead7
Update `client-errors` without `parser error` tests
sosukesuzuki Jan 11, 2024
159c39c
Add FIXME comment
sosukesuzuki Jan 11, 2024
eca036c
Use `closeServerAsPromise` for `client-dispatch`
sosukesuzuki Jan 11, 2024
62dd4ff
Use `closeServerAsPromise` for `client-connect`
sosukesuzuki Jan 11, 2024
bc36686
Leave some tests on tap
sosukesuzuki Jan 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
272 changes: 1 addition & 271 deletions test/client-connect.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,277 +6,7 @@ const http = require('http')
const EE = require('events')
const { kBusy } = require('../lib/core/symbols')

test('basic connect', (t) => {
t.plan(3)

const server = http.createServer((c) => {
t.fail()
})
server.on('connect', (req, socket, firstBodyChunk) => {
socket.write('HTTP/1.1 200 Connection established\r\n\r\n')

let data = firstBodyChunk.toString()
socket.on('data', (buf) => {
data += buf.toString()
})

socket.on('end', () => {
socket.end(data)
})
})
t.teardown(server.close.bind(server))

server.listen(0, async () => {
const client = new Client(`http://localhost:${server.address().port}`)
t.teardown(client.close.bind(client))

const signal = new EE()
const promise = client.connect({
signal,
path: '/'
})
t.equal(signal.listenerCount('abort'), 1)
const { socket } = await promise
t.equal(signal.listenerCount('abort'), 0)

let recvData = ''
socket.on('data', (d) => {
recvData += d
})

socket.on('end', () => {
t.equal(recvData.toString(), 'Body')
})

socket.write('Body')
socket.end()
})
})

test('connect error', (t) => {
t.plan(1)

const server = http.createServer((c) => {
t.fail()
})
server.on('connect', (req, socket, firstBodyChunk) => {
socket.destroy()
})
t.teardown(server.close.bind(server))

server.listen(0, async () => {
const client = new Client(`http://localhost:${server.address().port}`)
t.teardown(client.close.bind(client))

try {
await client.connect({
path: '/'
})
} catch (err) {
t.ok(err)
}
})
})

test('connect invalid opts', (t) => {
t.plan(6)

const client = new Client('http://localhost:5432')

client.connect(null, err => {
t.type(err, errors.InvalidArgumentError)
t.equal(err.message, 'invalid opts')
})

try {
client.connect(null, null)
t.fail()
} catch (err) {
t.type(err, errors.InvalidArgumentError)
t.equal(err.message, 'invalid opts')
}

try {
client.connect({ path: '/' }, null)
t.fail()
} catch (err) {
t.type(err, errors.InvalidArgumentError)
t.equal(err.message, 'invalid callback')
}
})

test('connect wait for empty pipeline', (t) => {
t.plan(7)

let canConnect = false
const server = http.createServer((req, res) => {
res.end()
canConnect = true
})
server.on('connect', (req, socket, firstBodyChunk) => {
t.equal(canConnect, true)
socket.write('HTTP/1.1 200 Connection established\r\n\r\n')

let data = firstBodyChunk.toString()
socket.on('data', (buf) => {
data += buf.toString()
})

socket.on('end', () => {
socket.end(data)
})
})
t.teardown(server.close.bind(server))

server.listen(0, async () => {
const client = new Client(`http://localhost:${server.address().port}`, {
pipelining: 3
})
t.teardown(client.close.bind(client))

client.request({
path: '/',
method: 'GET'
}, (err) => {
t.error(err)
})
client.once('connect', () => {
process.nextTick(() => {
t.equal(client[kBusy], false)

client.connect({
path: '/'
}, (err, { socket }) => {
t.error(err)
let recvData = ''
socket.on('data', (d) => {
recvData += d
})

socket.on('end', () => {
t.equal(recvData.toString(), 'Body')
})

socket.write('Body')
socket.end()
})
t.equal(client[kBusy], true)

client.request({
path: '/',
method: 'GET'
}, (err) => {
t.error(err)
})
})
})
})
})

test('connect aborted', (t) => {
t.plan(6)

const server = http.createServer((req, res) => {
t.fail()
})
server.on('connect', (req, c, firstBodyChunk) => {
t.fail()
})
t.teardown(server.close.bind(server))

server.listen(0, () => {
const client = new Client(`http://localhost:${server.address().port}`, {
pipelining: 3
})
t.teardown(client.destroy.bind(client))

const signal = new EE()
client.connect({
path: '/',
signal,
opaque: 'asd'
}, (err, { opaque }) => {
t.equal(opaque, 'asd')
t.equal(signal.listenerCount('abort'), 0)
t.type(err, errors.RequestAbortedError)
})
t.equal(client[kBusy], true)
t.equal(signal.listenerCount('abort'), 1)
signal.emit('abort')

client.close(() => {
t.pass()
})
})
})

test('basic connect error', (t) => {
t.plan(2)

const server = http.createServer((c) => {
t.fail()
})
server.on('connect', (req, socket, firstBodyChunk) => {
socket.write('HTTP/1.1 200 Connection established\r\n\r\n')

let data = firstBodyChunk.toString()
socket.on('data', (buf) => {
data += buf.toString()
})

socket.on('end', () => {
socket.end(data)
})
})
t.teardown(server.close.bind(server))

server.listen(0, async () => {
const client = new Client(`http://localhost:${server.address().port}`)
t.teardown(client.close.bind(client))

const _err = new Error()
client.connect({
path: '/'
}, (err, { socket }) => {
t.error(err)
socket.on('error', (err) => {
t.equal(err, _err)
})
throw _err
})
})
})

test('connect invalid signal', (t) => {
t.plan(2)

const server = http.createServer((req, res) => {
t.fail()
})
server.on('connect', (req, c, firstBodyChunk) => {
t.fail()
})
t.teardown(server.close.bind(server))

server.listen(0, () => {
const client = new Client(`http://localhost:${server.address().port}`)
t.teardown(client.destroy.bind(client))

client.on('disconnect', () => {
t.fail()
})

client.connect({
path: '/',
signal: 'error',
opaque: 'asd'
}, (err, { opaque }) => {
t.equal(opaque, 'asd')
t.type(err, errors.InvalidArgumentError)
})
})
})

// TODO: move to test/node-test/client-connect.js
metcoder95 marked this conversation as resolved.
Show resolved Hide resolved
test('connect aborted after connect', (t) => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When porting this test to node:test, the test fails with the message Promise resolution is still pending but the event loop has already resolved. I investigated the cause, but couldn't figure it out, so I'll leave it on tap. I'll investigate further later.

t.plan(3)

Expand Down