Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add cache testing #2623

Closed
wants to merge 13 commits into from
Closed

test: add cache testing #2623

wants to merge 13 commits into from

Conversation

tsctx
Copy link
Member

@tsctx tsctx commented Jan 17, 2024

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jan 17, 2024

Codecov Report

Attention: 176 lines in your changes are missing coverage. Please review.

Comparison is base (e39a632) 85.54% compared to head (fc5398f) 87.28%.
Report is 225 commits behind head on main.

Files Patch % Lines
lib/fetch/index.js 67.29% 52 Missing ⚠️
lib/fetch/util.js 37.17% 49 Missing ⚠️
lib/handler/RetryHandler.js 74.35% 30 Missing ⚠️
lib/cache/cache.js 65.71% 12 Missing ⚠️
lib/core/diagnostics.js 84.74% 9 Missing ⚠️
lib/api/readable.js 88.88% 5 Missing ⚠️
lib/fetch/headers.js 90.19% 5 Missing ⚠️
lib/client.js 95.23% 3 Missing ⚠️
lib/compat/dispatcher-weakref.js 57.14% 3 Missing ⚠️
lib/core/util.js 95.65% 2 Missing ⚠️
... and 5 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2623      +/-   ##
==========================================
+ Coverage   85.54%   87.28%   +1.73%     
==========================================
  Files          76       81       +5     
  Lines        6858     7293     +435     
==========================================
+ Hits         5867     6366     +499     
+ Misses        991      927      -64     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@KhafraDev KhafraDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure Every test here is already covered by WPTs. There is no reason to add these tests.

@tsctx
Copy link
Member Author

tsctx commented Jan 17, 2024

@KhafraDev #2612 (comment)

@KhafraDev
Copy link
Member

I think Matteo meant was that a test specifically for accessing the signal was needed, not that we need to duplicate the tests

@tsctx tsctx closed this Jan 17, 2024
@tsctx tsctx deleted the test/add-cache-test branch January 17, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants