-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove anti-pattern dispatcher hooks #2723
Conversation
The rationale seems fair to me. I had a little bit of an issue understanding its specific use case. However, I think we should provide the same lifecycle event in some other way almost native to Wrapping the body into a For the PR, it seems lint is not happy and we need to work on some tests 😅 |
Sorry, what do you mean? |
3aa30ca
to
03f680f
Compare
Point the PR to |
1c71f36
to
761bd7e
Compare
onBodySent on onRequestSent are footguns that easily cause bugs when implementing logic will send multiple requests, e.g. redirect and retry. To achieve similar functionality wrap body into a stream and listen to 'data' and 'end' events. Refs: #2722
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To achieve similar functionality wrap body into a stream and listen
to 'data' and 'end' events.
This is not the same. The reason those were added was essentially to avoid wrapping the body with a stream, because it adds overhead.
It is the same. But slower. However, they cause more harm than good as it is currently. What happens e.g. during a retry or redirect? When the same body is sent twice, possibly interleaved? The API is badly broken. |
Can you add a atest showing how to achieve the same? |
A test? Testing what? I can add an example in the docs if that's what you are looking for. |
That would be ok. |
No idea how/where to put this. But something like this would be the same thing: import { Readable } from 'node:stream'
import undici from 'undici'
function request(url, opts, onBodySent, onRequestSent) {
let body = !opts?.body || typeof opts.body?.pipe === 'function'
? opts.body
: Readable.from([opts.body])
body
.on('data', onBodySent)
.on('end', onRequestSent)
.pause()
return undici.request(url, { ...opts, body, })
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
onBodySent on onRequestSent are footguns that easily cause bugs
when implementing logic will send multiple requests, e.g. redirect
and retry.
To achieve similar functionality wrap body into a stream and listen
to 'data' and 'end' events.
Refs: #2722