add support for keep-alive timeout server hint #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronag
force-pushed
the
keep-alive-timeout
branch
4 times, most recently
from
be8a436
to
e79c2dc
Compare
ronag
force-pushed
the
keep-alive-timeout
branch
2 times, most recently
from
70c3d85
to
48b7dfe
Compare
ronag
force-pushed
the
keep-alive-timeout
branch
from
48b7dfe
to
b1d98a4
Compare
szmarczak
reviewed
Jul 30, 2020
szmarczak
reviewed
Jul 30, 2020
| if (m) { | ||
| const keepAliveTimeout = Number(m[1]) * 1000 | ||
| // Set timeout to half of hint to account for timing inaccuracies. | ||
| client[kKeepAliveTimeout] = Math.min(keepAliveTimeout - 500, client[kIdleTimeout]) |
There was a problem hiding this comment.
What is this is negative or a zero? Does it throw?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.