Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: fix broken ci on windows and node v21 because of libuv bug #2941

Merged
merged 1 commit into from
Mar 10, 2024
Merged

ci: fix broken ci on windows and node v21 because of libuv bug #2941

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 3 additions & 9 deletions test/node-test/debug.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,7 @@ const { tspl } = require('@matteo.collina/tspl')
// eslint-disable-next-line no-control-regex
const removeEscapeColorsRE = /[\u001b\u009b][[()#;?]*(?:[0-9]{1,4}(?:;[0-9]{0,4})*)?[0-9A-ORZcf-nqry=><]/g

// see https://github.com/nodejs/node/issues/51766
const skip = process.version === 'v21.6.2' && process.platform === 'win32'

test('debug#websocket', { skip }, async t => {
test('debug#websocket', async t => {
const assert = tspl(t, { plan: 8 })
const child = spawn(
process.execPath,
Expand Down Expand Up @@ -48,10 +45,9 @@ test('debug#websocket', { skip }, async t => {
})

await assert.completed
child.kill()
})

test('debug#fetch', { skip }, async t => {
test('debug#fetch', async t => {
const assert = tspl(t, { plan: 7 })
const child = spawn(
process.execPath,
Expand Down Expand Up @@ -83,10 +79,9 @@ test('debug#fetch', { skip }, async t => {
})

await assert.completed
child.kill()
})

test('debug#undici', { skip }, async t => {
test('debug#undici', async t => {
// Due to Node.js webpage redirect
const assert = tspl(t, { plan: 7 })
const child = spawn(
Expand Down Expand Up @@ -121,7 +116,6 @@ test('debug#undici', { skip }, async t => {
})

await assert.completed
child.kill()
})

function extractLines (chunks) {
Expand Down