Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #3110 for details. Both should merge at the same time.
This relates to...
#3103
Rationale
Add 5.x specific deployment logic to v5.x branch
Changes
Backport
release
workflow and release script from main, ensure change logs are generated against previous 5.x release, ensure tag on npm publish isfive
, and removepublish-undici-types
workflow (now taken care of duringrelease
workflow)Notes
Assuming the
release
environment is set to Protected branches only, branch protection rules must be added forv5.x
branch, as this change will enable automated release on push.Alternatively (for added security) -- the release environment should be limited to exactly the
main
orv5.x
branch, in addition to adding branch protection rules tov5.x
.If the following protections are added:
![CleanShot 2024-04-13 at 11 13 25@2x](https://private-user-images.githubusercontent.com/1062734/322214568-fe456279-5a16-4f85-a0ab-2dfc78f4cf45.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQ0NDk5ODYsIm5iZiI6MTcyNDQ0OTY4NiwicGF0aCI6Ii8xMDYyNzM0LzMyMjIxNDU2OC1mZTQ1NjI3OS01YTE2LTRmODUtYTBhYi0yZGZjNzhmNGNmNDUucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDgyMyUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA4MjNUMjE0ODA2WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9YjNhZmZhMGE5ZjNiZjRhZWMwYjI5MTA3MjAyMGFjZDViNDY2OTQ1ZDRhMGRhMDJmZmY2OTA1YzExYzZhOTgxNSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.GiUL6tCzNBb2XJSPTZbXIMgGGq7abS3sShX9pFUOVM8)
Then this is what a malicious branch and workflow run would look like, with the release blocked:
https://github.com/mweberxyz/nodejs-undici/commits/malicious/
https://github.com/mweberxyz/nodejs-undici/actions/runs/8674454300
Status