-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fetch: limit web streams usage in body mixin methods #3113
Conversation
I'm running tests, I'll fix them 🧪 |
lib/web/fetch/util.js
Outdated
@@ -1055,6 +1055,11 @@ async function fullyReadBody (body, processBody, processBodyError) { | |||
// with taskDestination. | |||
const errorSteps = processBodyError | |||
|
|||
if (typeof body.source === 'string') { | |||
successSteps(new TextEncoder().encode(body.source)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not check your code and if this makes sense. But I think this wil break without-intl builds . check how we implemented utf8Decode and look if you can implement something like utf8Encode?!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you very much for your suggestion I will try this
Co-authored-by: tsctx <91457664+tsctx@users.noreply.github.com>
There are related failures, but I don't necessarily think this should land as-is even if those failures were fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(making sure to block this)
I wonder if you have a suggestion, if it's healthy to keep it as it is, I'll close this place @KhafraDev |
This PR aims to improve performance by optimizing the processing of webflows in the fetch module.
This experiment was already done by @KhafraDev , I just opened a pr
I thought there would be discussion about it and it might benefit fetch 🚀
#2164
here is a benchmark made by @KhafraDev 🙏
benchmarks: