Refactor example documentation structure and add CacheableLookup example #3363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronag
reviewed
Jun 23, 2024
DarkGL
force-pushed
the
chore/cacheable-lookup-doc
branch
from
b56765f to
d2fe417
Compare
|
Fixed |
ronag
approved these changes
Jun 23, 2024
|
@metcoder95 @KhafraDev there is actually one problem with this example. If an upstream fails with e.g. ENOTFOUND or some other error that indicated that we cannot connect to the origin then it should be removed from the cache. Maybe future improvement? |
ronag
added a commit
to nxtedition/undici
that referenced
this pull request
Jun 25, 2024
* upstream/forward-dispatch: fix: forward dispatch return value Refactor example documentation structure and add CacheableLookup example (nodejs#3363)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relates to...
#3349
Rationale
Changes
Refactor example documentation structure and add CacheableLookup example
Features
Bug Fixes
Breaking Changes and Deprecations
Status