feat!: drop throwOnError #3451
feat!: drop throwOnError #3451
Conversation
|
|
||
| class RequestHandler extends AsyncResource { | ||
| constructor (opts, callback) { | ||
| if (!opts || typeof opts !== 'object') { | ||
| throw new InvalidArgumentError('invalid opts') | ||
| } | ||
|
|
||
| const { signal, method, opaque, body, onInfo, responseHeaders, throwOnError, highWaterMark } = opts | ||
| const { signal, method, opaque, body, onInfo, responseHeaders, highWaterMark } = opts | ||
|
|
There was a problem hiding this comment.
throw error if throwError === true
There was a problem hiding this comment.
Shall we? Its a major, it means overall that it won't work if not documented.
There was a problem hiding this comment.
Doesn't hurt? Less suprising to people that don't update their code.
mcollina
added
the
semver-major
|
@metcoder95 Why was this removed without a linked issue or discussion or rationale given?.. |
|
For further reference, as i believe we missed more context while working on this:
|
This relates to...
Rationale
Changes
Features
Bug Fixes
Breaking Changes and Deprecations
Status