feat: add DNS interceptor #3490
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It is on a super early state, but should be ok to review @ronag
|
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
ronag
reviewed
Aug 21, 2024
|
I'm super busy this month. Will do my best to provide feedback. But for now I mostly have time for high level feedback. LGTM so far. |
|
We can improve the caching with a self made LRU if we want, but I'd rather explore that in further PRs |
metcoder95
commented
Sep 2, 2024
lib/interceptor/dns.js
Outdated
| return this.pick( | ||
| origin, | ||
| hostnameRecords, | ||
| affinity ?? this.lastIpFamily === 4 ? 6 : 4 |
There was a problem hiding this comment.
fix: respect dualStack
metcoder95
commented
Sep 2, 2024
Uzlopak
reviewed
Sep 11, 2024
|
I'll be fixing the tests down the path; hopefully the Windows one are easier to fix |
metcoder95
force-pushed
the
feat/dns-cache
branch
from
570702c
to
9b01a09
Compare
|
CI does not seem happy |
|
I'm intrigued about the Ubuntu ones, but the Window's ones seem odd. I'll check them throughout the week |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3350
WIP