Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: only create wasm buffer if requested #3499

Merged
merged 1 commit into from
Aug 24, 2024
Merged

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Aug 24, 2024

should speed up the start up time, because we avoid to process the 70 kb of non-simd wasm base64-string to a buffer, just to never use it.

@Uzlopak Uzlopak force-pushed the only-wasm-buffer-if-needed branch from 45a08a8 to b2702f2 Compare August 24, 2024 01:00
@Uzlopak Uzlopak merged commit a3761f9 into main Aug 24, 2024
38 checks passed
@Uzlopak Uzlopak deleted the only-wasm-buffer-if-needed branch August 24, 2024 01:16
Copy link
Contributor

The backport to v6.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-v6.x v6.x
# Navigate to the new working tree
cd .worktrees/backport-v6.x
# Create a new branch
git switch --create backport-3499-to-v6.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a3761f944fbd0cb47340e4f20c047f177a6ca18d
# Push it to GitHub
git push --set-upstream origin backport-3499-to-v6.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-v6.x

Then, create a pull request where the base branch is v6.x and the compare/head branch is backport-3499-to-v6.x.

@github-actions github-actions bot mentioned this pull request Dec 3, 2024
This was referenced Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants