remove third party everything support in fetch #3502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KhafraDev
added
the
semver-major
ronag
approved these changes
Aug 24, 2024
|
Node v22.7.0 broke some of the autobahn tests, confirmed it locally. When running in v22.6.0, all the tests pass. It wasn't caught because the autobahn suite only runs when changes to |
|
It's probably the buffer bugs, thinking about it. I'm almost certain it's nodejs/node#54521 because the failing tests send strings, which are converted to a buffer with Buffer.from. They also send thousands of messages which would make them optimize. |
|
@KhafraDev |
…afraDev/undici into remove-third-party-everything
KhafraDev
commented
Aug 27, 2024
| @@ -400,16 +400,6 @@ class Request { | |||
|
|
|||
| // 29. If signal is not null, then make this’s signal follow signal. | |||
| if (signal != null) { | |||
| if ( | |||
There was a problem hiding this comment.
this is no longer needed because we are actually validating signal in webidl now
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Third party Blob, FormData, and AbortController in fetch should never have landed. Even after it did, there was never any documentation on it - the only evidence that this was a feature was in tests and a few comments on issues.
Support is so bad, currently, in fact, that webidl skips validation entirely. Take
webidl.converters.Blobfor example: it's an interface converter (ie. validating that an object is an instance of a class), but when passed thestrict: falseoption, it wouldn't perform any validation.I understand that support was added for performance reasons, but it's something that we should have let node core fix, rather than "node-ifying" the spec. For use cases that are not possible with fetch, we should start recommending undici directly.