Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): add missing cache prop to RequestInit #3569

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

rindeal
Copy link
Contributor

@rindeal rindeal commented Sep 9, 2024

Also sort the props.

This relates to...

Rationale

Changes

Features

Bug Fixes

Breaking Changes and Deprecations

Status

@eXhumer
Copy link
Contributor

eXhumer commented Sep 9, 2024

Lint issues, use 2 spaces instead of 4.

I don't think undici.fetch supports caching yet (See #2760).

If you want to implement some sort of in-memory caching, see #2760 (comment).

@rindeal
Copy link
Contributor Author

rindeal commented Sep 9, 2024

Lint issues, use 2 spaces instead of 4.

yeah, will fix

I don't think undici.fetch supports caching yet (See #2760).

If you want to implement some sort of in-memory caching, see #2760 (comment).

The prop is supported and that's all that matters in this case

{
key: 'cache',
converter: webidl.converters.DOMString,
// https://fetch.spec.whatwg.org/#requestcache
allowedValues: requestCache
},

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some type tests for this? We use tsd.

Copy link
Contributor

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And tomorrow somebody argues, that because the cache field is in the types, we need to implement asap caching.

@rindeal
Copy link
Contributor Author

rindeal commented Sep 9, 2024

Can you add some type tests for this? We use tsd.

Copy link
Contributor

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rindeal
Copy link
Contributor Author

rindeal commented Sep 16, 2024

bump @mcollina

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 770b2db into nodejs:main Oct 15, 2024
32 checks passed
@rindeal rindeal deleted the patch-1 branch October 16, 2024 06:37
@github-actions github-actions bot mentioned this pull request Dec 3, 2024
This was referenced Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants