Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove symbols from web specs #3633

Merged
merged 5 commits into from
Sep 22, 2024
Merged

Remove symbols from web specs #3633

merged 5 commits into from
Sep 22, 2024

Conversation

KhafraDev
Copy link
Member

No longer exposes symbols in FormData, Request, and Response. The same change was made for Headers a little while back.

@KhafraDev
Copy link
Member Author

@nodejs/undici

mcollina
mcollina approved these changes Sep 22, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@KhafraDev KhafraDev merged commit 45dceea into nodejs:main Sep 22, 2024
32 checks passed
@KhafraDev KhafraDev deleted the remove-symbols branch September 22, 2024 22:48
@KhafraDev
Copy link
Member Author

KhafraDev commented Sep 22, 2024 •
edited
Loading

Oops this might have broke the WPT runner. Luckily the fix is easy, will have a PR soon.
https://github.com/nodejs/undici/actions/runs/10965958483/job/30483682935#step:8:2493

@github-actions github-actions bot mentioned this pull request Dec 3, 2024
Merged
This was referenced Dec 16, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsctx tsctx tsctx approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KhafraDev @mcollina @tsctx