Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: simplify busy #366

Merged
merged 1 commit into from
Aug 28, 2020
Merged

refactor: simplify busy #366

merged 1 commit into from
Aug 28, 2020

Conversation

ronag
Copy link
Member

@ronag ronag commented Aug 28, 2020

This significantly simplifies the busy logic. Slightly changes behavior of busy. However, since we now have 'drain' it has minor impact.

Actually seems to improve performance slightly.

The difference is mostly for the Client.pipeline API.

@ronag ronag requested a review from mcollina August 28, 2020 10:02
@ronag

This comment has been minimized.

@ronag ronag added the semver-major Features or fixes that will be included in the next semver major release label Aug 28, 2020
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ronag ronag merged commit ade0cef into master Aug 28, 2020
@ronag ronag deleted the simplify-busy branch September 5, 2020 20:48
@ronag ronag restored the simplify-busy branch September 5, 2020 20:48
@mcollina mcollina deleted the simplify-busy branch January 17, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-major Features or fixes that will be included in the next semver major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants