-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
http2: extract listenHandlers and one bugfix #3722
Conversation
// We cannot recover, so best to close the session and the socket | ||
const err = this[kError] || new SocketError(`HTTP/2: "GOAWAY" frame received with code ${code}`, util.getSocketInfo(this)) | ||
const err = this[kError] || new SocketError(`HTTP/2: "GOAWAY" frame received with code ${errorCode}`, util.getSocketInfo(this[kSocket])) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here we have a Http2Session, so we have to pass this[kSocket] to getSocketInfo
closed = true | ||
}) | ||
socket[kClosed] = false | ||
socket.on('close', onSocketClose) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess there is a reason to use nodes own event handler and not undicis one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not on top of my mind, feel free to change it to the undici
's one 👍
closed = true | ||
}) | ||
socket[kClosed] = false | ||
socket.on('close', onSocketClose) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not on top of my mind, feel free to change it to the undici
's one 👍
No description provided.