Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dns interceptor affinity #3778

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

luddd3
Copy link
Contributor

@luddd3 luddd3 commented Oct 28, 2024

This relates to...

DNS interceptor

Rationale

  • error was thrown when a single ip address was resolved with dual-stack: "Cannot read properties of null (reading 'offset')"
  • pick always started on the second ip address if multiple were resolved
  • affinity was ignored with dual-stack

Changes

Always start pick with the first ip address when multiple are resolved (ipv4 before ipv6)

Features

Prefer affinity family with dual-stack, fallback to other family

Bug Fixes

Handle single ip address resolved with dual-stack

Breaking Changes and Deprecations

Status

* error was thrown when a single ip address was resolved
* `pick` always started on the second ip address if multiple
were resolved
* affinity was ignored with dual-stack
Copy link
Member

@metcoder95 metcoder95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@metcoder95 metcoder95 merged commit d78b7ca into nodejs:main Oct 29, 2024
29 of 32 checks passed
@luddd3 luddd3 deleted the fix-dns-interceptor-affinity branch October 29, 2024 12:50
@github-actions github-actions bot mentioned this pull request Dec 3, 2024
This was referenced Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants