Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update return type of RetryCallback #3851

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

mqayyuum
Copy link
Contributor

@mqayyuum mqayyuum commented Nov 20, 2024

This relates to...

#3824

Changes

Fix the return type of RetryCallback

Status

@mcollina
Copy link
Member

Thanks for opening a PR! Can you please add a unit test? We use tsd for typescript

@mcollina mcollina merged commit a1fb2cc into nodejs:main Nov 22, 2024
38 checks passed
Copy link
Contributor

The backport to v6.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-v6.x v6.x
# Navigate to the new working tree
cd .worktrees/backport-v6.x
# Create a new branch
git switch --create backport-3851-to-v6.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a1fb2cc17b4055898bdc7251a903d7e7d62a4387
# Push it to GitHub
git push --set-upstream origin backport-3851-to-v6.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-v6.x

Then, create a pull request where the base branch is v6.x and the compare/head branch is backport-3851-to-v6.x.

metcoder95 pushed a commit that referenced this pull request Nov 24, 2024
* Update return type

* add type tests

(cherry picked from commit a1fb2cc)
mcollina pushed a commit that referenced this pull request Nov 25, 2024
* Update return type

* add type tests

(cherry picked from commit a1fb2cc)

Co-authored-by: Qayyuum Harun <69181532+mqayyuum@users.noreply.github.com>
@github-actions github-actions bot mentioned this pull request Dec 3, 2024
@github-actions github-actions bot mentioned this pull request Dec 16, 2024
@github-actions github-actions bot mentioned this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants