-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for Timeout and Trailers #3854
Conversation
@@ -278,6 +283,7 @@ function shouldSendContentLength (method) { | |||
} | |||
|
|||
function writeH2 (client, request) { | |||
const requestTimeout = request.bodyTimeout ?? client[kBodyTimeout] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was quite unsure if using the bodyTimeout
for this, and adding a new one. But given the nature of the timeout, using the body's one should be enough.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm once windows passes
e438544
to
91cf1a0
Compare
91cf1a0
to
da7e78b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This relates to...
Rationale
Changes
Features
Bug Fixes
Breaking Changes and Deprecations
Status