Drop node v18 #3880
Drop node v18 #3880
Conversation
Signed-off-by: Matteo Collina <hello@matteocollina.com>
|
cc @trivikr |
Signed-off-by: Matteo Collina <hello@matteocollina.com>
|
I haven't seen any reason to drop v18. Nothing in fetch or other web specs needs it gone, and it's in maintenance mode for another 5 months. Is there any reason other than precedence? If precedence is the main concern, there were genuine issues with previous versions of node that required us to drop them - I can't think of any similar issues in v18. |
|
@KhafraDev I'd provided estimates on how long unidici maintainers have to support Node.js 18.x in #3386 (comment) after it's end-of-life. Matteo also provided how dropping Node.js 18.x will ease maintenance of undici@v7 in #3386 (comment) |
|
As per #3386 (comment) on tracking issue, @KhafraDev is -0 in dropping support for Node.js 18.x in |
| @@ -128,7 +128,7 @@ | |||
| "ws": "^8.11.0" | |||
| }, | |||
| "engines": { | |||
| "node": ">=18.17" | |||
| "node": ">=20.18.1" | |||
There was a problem hiding this comment.
what was the reason for choosing this particular version, @mcollina ?
Since it drops not only 18.x, but almost entire 20.x except its latest release available today
There was a problem hiding this comment.
Because it's the latest version that was available at the time of the release. You should not be using anything else.
There was a problem hiding this comment.
The latest Android version is 15, so the all developers should do applications only for Android 15?
I just decided to install undici, but it now forces me to update my Node 20.18.0 to 20.18.1 only because mcollina decided so.
Did you know that minimum requirements are set only to indicate that with lower requirements, the software will not work, and not because some person decides for others what to use and what not to use?
There was a problem hiding this comment.
The latest Android version is 15, so the all developers should do applications only for Android 15?
This is not a good analogy. A good analogy is slightly different: should Google recommend the use of anything but the latest patch available for that given version? As we speak, this is 15.0.0_r5. Why would Google recommend the use of a version that contains known vulnerabilities? You can find the details related to Android CVEs here: https://source.android.com/docs/security/bulletin/2024-11-01#spl-vulnerability-details.
There was a problem hiding this comment.
engines.node field is not about "recommendations".
The purpose of this field is to show which versions of Node.js the library will work on and which will not.
Wrong use of this field feels like not a recommendation, but a force to update Node.js.
No description provided.