Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the responseError interceptor backward compatible, add a body property #3891

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Make the responseError interceptor backward compatible, add a body property #3891

merged 1 commit into from
Nov 27, 2024

Conversation

mcollina
Copy link
Member

This makes the responseError interceptor backward compatible.
throwOnError added a err.body property, while the interceptor adds a err.data property. I've renamed data to body.

@mcollina
Make the responseError interceptor backward compatible, add a body pr…
cb5ffcc 
…operty

Signed-off-by: Matteo Collina <hello@matteocollina.com>
mertcanaltin
mertcanaltin approved these changes Nov 27, 2024
View reviewed changes
Copy link
Member

@mertcanaltin mertcanaltin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina mcollina merged commit 3c67a3d into main Nov 27, 2024
36 of 37 checks passed
@mcollina mcollina deleted the fix-response-error-body branch November 27, 2024 13:37
@github-actions github-actions bot mentioned this pull request Dec 3, 2024
Merged
This was referenced Dec 16, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mertcanaltin mertcanaltin mertcanaltin approved these changes

@ronag ronag Awaiting requested review from ronag

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcollina @mertcanaltin