feat(pool): forward connect and disconnect events #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronag
reviewed
Jan 6, 2021
Make the `Pool` forward the `connect` and `disconnect` events emitted by its clients. The `Client` instance that emitted the event is passed as argument.
ronag
approved these changes
Jan 6, 2021
Codecov Report
@@ Coverage Diff @@
## master #510 +/- ##
=======================================
Coverage 99.60% 99.60%
=======================================
Files 15 15
Lines 1268 1274 +6
=======================================
+ Hits 1263 1269 +6
Misses 5 5
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the
Poolforward theconnectanddisconnectevents emitted by itsclients. The
Clientinstance that emitted the event is passed asthe argument.
Fixes #509