Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Pool/Client.url #527

Merged
merged 2 commits into from
Jan 16, 2021
Merged

feat: Add Pool/Client.url #527

merged 2 commits into from
Jan 16, 2021

Conversation

ronag
Copy link
Member

@ronag ronag commented Jan 16, 2021

No description provided.

@ronag ronag requested a review from mcollina January 16, 2021 13:25
@ronag ronag changed the title feat: Add Pool/Client.origin feat: Add Pool/Client.url Jan 16, 2021
@codecov-io
Copy link

codecov-io commented Jan 16, 2021

Codecov Report

Merging #527 (df522da) into master (2ce227e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #527   +/-   ##
=======================================
  Coverage   99.55%   99.55%           
=======================================
  Files          16       16           
  Lines        1344     1354   +10     
=======================================
+ Hits         1338     1348   +10     
  Misses          6        6           
Impacted Files Coverage Δ
lib/core/client.js 99.46% <100.00%> (-0.02%) ⬇️
lib/core/util.js 97.26% <100.00%> (+0.96%) ⬆️
lib/pool.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ce227e...1035ccb. Read the comment docs.

@ronag ronag force-pushed the pool.url branch 2 times, most recently from 3948e5a to abe7fda Compare January 16, 2021 13:35
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ronag ronag merged commit d39c0fe into master Jan 16, 2021
@ronag ronag deleted the pool.url branch January 16, 2021 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants