feat: Pool size & running #535
Conversation
|
Tests needs fixing |
|
@dnlup Feel free to sort out the tests here if you want. But I was referring to the failures on master. |
ronag
force-pushed
the
pool-size-pending
branch
from
bae5955 to
a7cf29a
Compare
ronag
force-pushed
the
pool-size-pending
branch
from
a7cf29a to
25856c3
Compare
Codecov Report
@@ Coverage Diff @@
## master #535 +/- ##
==========================================
- Coverage 99.63% 99.56% -0.07%
==========================================
Files 16 16
Lines 1366 1385 +19
==========================================
+ Hits 1361 1379 +18
- Misses 5 6 +1
Continue to review full report at Codecov.
|
ronag
force-pushed
the
pool-size-pending
branch
2 times, most recently
from
719cf03 to
eed6638
Compare
ronag
force-pushed
the
pool-size-pending
branch
from
f1f57a9 to
35d4e4f
Compare
| if (pool[kNeedDrain] && !this.busy) { | ||
| pool[kNeedDrain] = false | ||
| pool.emit('drain') | ||
| } |
There was a problem hiding this comment.
I don't understand the question.
There was a problem hiding this comment.
you removed the if (queue.isEmpty()) check. Why?
There was a problem hiding this comment.
I replaced it with !this.busy which contains the same check through this[kPending] > 0
There was a problem hiding this comment.
the empty check is moved to just if (pool[kClosedResolve] && queue.isEmpty()) {
No description provided.