-
Notifications
You must be signed in to change notification settings - Fork 572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix missing client arg #555
fix missing client arg #555
Conversation
Would be nice with a test. Is this the only occurance? |
Yeah only occurrence (did a search for |
In the upgrade test can you add a check for disconnect + correct args. I think you can just register a handler in one of the existing tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add a unit test?
Also found another test for this but its not upgrade related so this new case is a good addition https://github.com/nodejs/undici/blob/master/test/client.js#L980 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
I think this is semver-major cc @ronag. |
This comment has been minimized.
This comment has been minimized.
It is semver major. A fix for #544 which we haven't released, |
closes #554
doc update included in #550