Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove Node 10 support #623

Merged
merged 4 commits into from
Mar 26, 2021
Merged

fix: Remove Node 10 support #623

merged 4 commits into from
Mar 26, 2021

Conversation

ronag
Copy link
Member

@ronag ronag commented Mar 26, 2021

Fixes: #622

@ronag ronag added this to the 4.0 milestone Mar 26, 2021
@ronag ronag requested a review from mcollina March 26, 2021 10:07
@codecov-io
Copy link

codecov-io commented Mar 26, 2021 •
edited
Loading

Codecov Report

Merging #623 (e809bc3) into main (b3dd69f) will decrease coverage by 0.41%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #623      +/-   ##
==========================================
- Coverage   99.10%   98.68%   -0.42%     
==========================================
  Files          17       18       +1     
  Lines        1446     1904     +458     
==========================================
+ Hits         1433     1879     +446     
- Misses         13       25      +12
Impacted Files Coverage Δ
lib/core/util.js 97.29% <ø> (+1.24%) ⬆️
lib/api/api-request.js 100.00% <100.00%> (ø)
lib/node/http-parser.js 75.00% <0.00%> (-25.00%) ⬇️
lib/llhttp/parser.js 92.36% <0.00%> (ø)
lib/core/client.js 99.33% <0.00%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3dd69f...e809bc3. Read the comment docs.

mcollina
mcollina requested changes Mar 26, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please update the minimum runtime in package.json to v12.18 (or 10.20)?

.github/workflows/nodejs.yml Outdated Show resolved Hide resolved
@ronag @mcollina
Update .github/workflows/nodejs.yml
e809bc3 
Co-authored-by: Matteo Collina <hello@matteocollina.com>
@ronag
Copy link
Member Author

ronag commented Mar 26, 2021

Can you please update the minimum runtime in package.json to v12.18 (or 10.20)?

Where do I do this?

@dnlup
Copy link
Contributor

dnlup commented Mar 26, 2021

Can you please update the minimum runtime in package.json to v12.18 (or 10.20)?

Where do I do this?

We should add the engines field: https://docs.npmjs.com/cli/v7/configuring-npm/package-json#engines

@ronag ronag requested a review from mcollina March 26, 2021 10:20
mcollina
mcollina approved these changes Mar 26, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ronag ronag merged commit d0328b3 into main Mar 26, 2021
@jkyberneees jkyberneees mentioned this pull request Sep 15, 2021
Merged
4 tasks
@Uzlopak Uzlopak deleted the node10 branch February 21, 2024 12:39
crysmags pushed a commit to crysmags/undici that referenced this pull request Feb 27, 2024
@ronag @mcollina @crysmags
fix: Remove Node 10 support (nodejs#623)
da9eeb8 
* fix: Remove Node 10 support

Fixes: nodejs#622

* Update .github/workflows/nodejs.yml

Co-authored-by: Matteo Collina <hello@matteocollina.com>

* fixup

Co-authored-by: Matteo Collina <hello@matteocollina.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnlup dnlup dnlup approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

Drop support for Node v10
4 participants
@ronag @codecov-io @dnlup @mcollina