feat: Add callback context and redirect history 2 #769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ShogunPanda PTAL |
ronag
force-pushed
the
698
branch
2 times, most recently
from
165d7c3 to
615e8c6
Compare
ronag
commented
Apr 24, 2021
lib/handler/redirect.js
Outdated
| this.abort = abort | ||
| this.handler.onConnect(abort) | ||
| this.handler.onConnect(abort, { ...context, history: this.history }) |
There was a problem hiding this comment.
I'm thinking maybe we should put history as a symbol we make public as to avoid collisions in the future?
There was a problem hiding this comment.
We could, but I think the external API might look a little complicated.
|
LGTM! |
Codecov Report
@@ Coverage Diff @@
## main #769 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 24 24
Lines 1906 1918 +12
=========================================
+ Hits 1906 1918 +12
Continue to review full report at Codecov.
|
ronag
commented
Apr 24, 2021
ronag
commented
Apr 24, 2021
crysmags
pushed a commit
to crysmags/undici
that referenced
this pull request
Feb 27, 2024
* feat: Add callback context and redirect history. * feat: Updated TypeScript types. * fix: Make sure context exist before modifying it. * fixup * fixup * fixup * perf: reuse redirect handler * fixup * fixup * fixuP * fixup * fixup * Apply suggestions from code review * fixup Co-authored-by: Paolo Insogna <paolo@cowtech.it>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.