feat: implement body mixin on Readable

[ronag]

Port over PR from node core. It will not be possible to land
these changes on core due to ecosystem breakage.

Refs: nodejs/node#39520

[codecov-commenter]

Codecov Report

Merging #907 (b19c11b) into main (11c2db1) will decrease coverage by 1.05%.
The diff coverage is 77.77%.

@@            Coverage Diff             @@
##             main     #907      +/-   ##
==========================================
- Coverage   99.57%   98.52%   -1.06%     
==========================================
  Files          26       27       +1     
  Lines        2132     2230      +98     
==========================================
+ Hits         2123     2197      +74     
- Misses          9       33      +24     

Impacted Files	Coverage Δ
lib/api/readable.js	77.35% <77.35%> (ø)
lib/api/api-request.js	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11c2db1...b19c11b. Read the comment docs.

[Ethan-Arrowood]

LGTM - do you want to make the type updates as well? Shouldn't be hard for this change

[mcollina]

Code looks good. I would recommend we mention what methods will be available in the docs. The .json() method might also deserve a special mention in the README

[ronag]

Fixed

[ronag]

master

[bench:run] │ Tests               │ Samples │        Result │ Tolerance │ Difference with slowest │
[bench:run] |─────────────────────|─────────|───────────────|───────────|─────────────────────────|
[bench:run] │ http - no keepalive │      10 │  6.39 req/sec │  ± 0.76 % │                       - │
[bench:run] |─────────────────────|─────────|───────────────|───────────|─────────────────────────|
[bench:run] │ http - keepalive    │      10 │  7.14 req/sec │  ± 1.22 % │               + 11.87 % │
[bench:run] |─────────────────────|─────────|───────────────|───────────|─────────────────────────|
[bench:run] │ undici - pipeline   │      10 │ 67.28 req/sec │  ± 1.88 % │              + 953.57 % │
[bench:run] |─────────────────────|─────────|───────────────|───────────|─────────────────────────|
[bench:run] │ undici - request    │      10 │ 68.88 req/sec │  ± 1.87 % │              + 978.72 % │
[bench:run] |─────────────────────|─────────|───────────────|───────────|─────────────────────────|
[bench:run] │ undici - stream     │      10 │ 70.55 req/sec │  ± 1.32 % │             + 1004.83 % │
[bench:run] |─────────────────────|─────────|───────────────|───────────|─────────────────────────|
[bench:run] │ undici - dispatch   │      10 │ 75.16 req/sec │  ± 2.16 % │             + 1076.97 % │

PR

[bench:run] │ Tests               │ Samples │        Result │ Tolerance │ Difference with slowest │
[bench:run] |─────────────────────|─────────|───────────────|───────────|─────────────────────────|
[bench:run] │ http - no keepalive │      10 │  6.43 req/sec │  ± 0.98 % │                       - │
[bench:run] |─────────────────────|─────────|───────────────|───────────|─────────────────────────|
[bench:run] │ http - keepalive    │      10 │  6.85 req/sec │  ± 1.93 % │                + 6.42 % │
[bench:run] |─────────────────────|─────────|───────────────|───────────|─────────────────────────|
[bench:run] │ undici - pipeline   │      10 │ 63.27 req/sec │  ± 2.41 % │              + 883.47 % │
[bench:run] |─────────────────────|─────────|───────────────|───────────|─────────────────────────|
[bench:run] │ undici - stream     │      10 │ 67.86 req/sec │  ± 1.31 % │              + 954.73 % │
[bench:run] |─────────────────────|─────────|───────────────|───────────|─────────────────────────|
[bench:run] │ undici - request    │      10 │ 68.78 req/sec │  ± 2.16 % │              + 969.07 % │
[bench:run] |─────────────────────|─────────|───────────────|───────────|─────────────────────────|
[bench:run] │ undici - dispatch   │      10 │ 73.52 req/sec │  ± 1.72 % │             + 1042.76 % │

[ronag]

@mcollina doesn't seem to have any significant perf regression.

[mcollina]

lgtm