fix(fetch): toUSVString #986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronag
commented
Aug 18, 2021
Codecov Report
@@ Coverage Diff @@
## main #986 +/- ##
==========================================
+ Coverage 90.80% 93.88% +3.08%
==========================================
Files 37 37
Lines 3587 3614 +27
==========================================
+ Hits 3257 3393 +136
+ Misses 330 221 -109
Continue to review full report at Codecov.
|
|
I don't understand what this brings. |
Placeholder for spec compliance. The spec says that these should be "usvstring"s. We need to eventually either implement |
|
We do the same thing for the |
|
Awesome, ok. Let's expose this from core. |
ronag
added a commit
to nxtedition/node
that referenced
this pull request
Aug 19, 2021
Expose toUSVString to it can be used by user libraries. Refs: nodejs/undici#986
ronag
added a commit
to nxtedition/node
that referenced
this pull request
Aug 19, 2021
Expose toUSVString to it can be used by user libraries. Refs: nodejs/undici#986
lpinca
pushed a commit
to nodejs/node
that referenced
this pull request
Aug 22, 2021
Expose toUSVString to it can be used by user libraries. PR-URL: #39814 Refs: nodejs/undici#986 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
lpinca
pushed a commit
to nodejs/node
that referenced
this pull request
Aug 22, 2021
Expose toUSVString so it can be used by user libraries. PR-URL: #39814 Refs: nodejs/undici#986 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
to nodejs/node
that referenced
this pull request
Aug 22, 2021
Expose toUSVString so it can be used by user libraries. PR-URL: #39814 Refs: nodejs/undici#986 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
to nodejs/node
that referenced
this pull request
Sep 4, 2021
Expose toUSVString so it can be used by user libraries. PR-URL: #39814 Refs: nodejs/undici#986 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
KhafraDev
pushed a commit
to KhafraDev/undici
that referenced
this pull request
Jun 23, 2022
* fix(fetch): toUSVString * fixup * fixup * fixup
crysmags
pushed a commit
to crysmags/undici
that referenced
this pull request
Feb 27, 2024
* fix(fetch): toUSVString * fixup * fixup * fixup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.