Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore failures building all recipes but fetch-source #10

Merged
merged 1 commit into from
Oct 1, 2019
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions bin/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,7 @@
__dirname="$(CDPATH= cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
image_tag_pfx=unofficial-build-recipe-
# all of our build recipes, new recipes just go into this list,
# 'fetch-source' is a special case and needs to go first
recipes=" \
fetch-source \
headers \
x86 \
musl \
Expand Down Expand Up @@ -54,6 +52,14 @@ distdir_promote="${distdir}/${disttype_promote}"
distoutdir="${distdir_promote}/${fullversion}"
mkdir -p $distoutdir

# Build fetch-source, needs to be the first and must succeed
docker run --rm \
-v ${sourcedir}:/out \
"${image_tag_pfx}fetch-source" \
"$unofficial_release_urlbase" "$disttype" "$customtag" "$datestring" "$commit" "$fullversion" "$source_url" \
> ${thislogdir}/fetch-source.log 2>&1

# Build all other recipes
for recipe in $recipes; do
# each recipe has 3 variable components:
# - individiaul ~/.ccache directory
Expand All @@ -63,17 +69,13 @@ for recipe in $recipes; do
mkdir -p "${ccachedir}/${recipe}"
sourcemount="-v ${sourcefile}:/home/node/node.tar.xz"
stagingmount="-v ${stagingoutdir}:/out"
if [[ "$recipe" = "fetch-source" ]]; then
stagingmount="-v ${sourcedir}:/out"
sourcemount=""
fi

# each recipe logs to its own log file in the $thislogdir directory
docker run --rm \
${ccachemount} ${sourcemount} ${stagingmount} \
"${image_tag_pfx}${recipe}" \
"$unofficial_release_urlbase" "$disttype" "$customtag" "$datestring" "$commit" "$fullversion" "$source_url" \
> ${thislogdir}/${recipe}.log 2>&1
> ${thislogdir}/${recipe}.log 2>&1 || echo "Failed to build recipe for ${recipe}"
done

# promote all assets in staging
Expand Down