Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: x64-glibc-217 build failed for v22.7.0 #152

Merged
merged 4 commits into from
Aug 27, 2024

Conversation

robinWongM
Copy link
Contributor

  1. Upgrade GCC version to 12 and Python version to 3.8
  2. Backport the patch from TCP_FASTOPEN_CONNECT build failure on CentOS 7 (or older kernels) c-ares/c-ares#850

@rvagg
Copy link
Member

rvagg commented Aug 24, 2024

@richardlau would you mind checking this? you probably have more familiarity with devtoolsets these days -- if this runs on centos7, we're still going to retain glibc 2.17 support, right?

@robinWongM
Copy link
Contributor Author

@richardlau would you mind checking this? you probably have more familiarity with devtoolsets these days -- if this runs on centos7, we're still going to retain glibc 2.17 support, right?

Yes, I've successfully tested the updated build process locally, and the resulting binary is compatible with glibc 2.17.
image

@richardlau richardlau merged commit 659282b into nodejs:main Aug 27, 2024
@robinWongM robinWongM deleted the patch-1 branch August 27, 2024 12:54
@robinWongM
Copy link
Contributor Author

@rvagg can you trigger a rebuild for this? thanks

./bin/queue-push.sh -v v22.7.0 -r x64-glibc-217

@rvagg
Copy link
Member

rvagg commented Aug 28, 2024

https://unofficial-builds.nodejs.org/logs/202408280055-v22.7.0/x64-glibc-217.log didn't work, maybe the recipe didn't propagate to a new build of the containers, needs investigation

@rvagg
Copy link
Member

rvagg commented Aug 28, 2024

#153

@robinWongM
Copy link
Contributor Author

robinWongM commented Aug 28, 2024

https://unofficial-builds.nodejs.org/logs/202408280055-v22.7.0/x64-glibc-217.log didn't work, maybe the recipe didn't propagate to a new build of the containers, needs investigation

@rvagg maybe we need to rebuild images

cd bin
./prepare-images.sh

@rvagg
Copy link
Member

rvagg commented Aug 28, 2024

Ran out of space on the root device, had other dramas, so I ended up clearing out the docker entirely and rebuilding them all again. I also reduced the ccache max size from 5G to 2G, each time we add a new recipe it ends up reserving that much on the root disk. Currently rebuilding and I can see glibc-217 working away right now so hopefully it'll drop in. We'll see what else succeeds and what passes. I think we have additional problems with other recipes to deal with.

@rvagg
Copy link
Member

rvagg commented Aug 30, 2024

k, well we got a glibc-217 but aside from musl, everything else seems borked, probably a python thing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants