-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: x64-glibc-217 build failed for v22.7.0 #152
Conversation
robinWongM
commented
Aug 24, 2024
- Upgrade GCC version to 12 and Python version to 3.8
- Backport the patch from TCP_FASTOPEN_CONNECT build failure on CentOS 7 (or older kernels) c-ares/c-ares#850
@richardlau would you mind checking this? you probably have more familiarity with devtoolsets these days -- if this runs on centos7, we're still going to retain glibc 2.17 support, right? |
Yes, I've successfully tested the updated build process locally, and the resulting binary is compatible with glibc 2.17. |
@rvagg can you trigger a rebuild for this? thanks ./bin/queue-push.sh -v v22.7.0 -r x64-glibc-217 |
https://unofficial-builds.nodejs.org/logs/202408280055-v22.7.0/x64-glibc-217.log didn't work, maybe the recipe didn't propagate to a new build of the containers, needs investigation |
@rvagg maybe we need to rebuild images cd bin
./prepare-images.sh |
Ran out of space on the root device, had other dramas, so I ended up clearing out the docker entirely and rebuilding them all again. I also reduced the ccache max size from 5G to 2G, each time we add a new recipe it ends up reserving that much on the root disk. Currently rebuilding and I can see glibc-217 working away right now so hopefully it'll drop in. We'll see what else succeeds and what passes. I think we have additional problems with other recipes to deal with. |
k, well we got a glibc-217 but aside from musl, everything else seems borked, probably a python thing |