Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixup armv6l recipes #34

Merged
merged 2 commits into from
May 5, 2021
Merged

fixup armv6l recipes #34

merged 2 commits into from
May 5, 2021

Conversation

richardlau
Copy link
Member

@richardlau richardlau commented May 4, 2021

Add the renamed armv6l-pre16 recipe to the explicit recipe list to build.

Add missing dependency (python3-distutils) for the new armv6l recipe to fix

ModuleNotFoundError: No module named 'distutils.spawn'

error. FWIW in https://github.com/nodejs/build/blob/master/ansible/roles/docker/templates/ubuntu1804_arm_cross.Dockerfile.j2 python3-distutils is installed as a dependency of python3-pip -- we do not need to install pip on the unofficial build Docker image as we're not running tap2junit here.

Refs: #33

@richardlau
Copy link
Member Author

mea culpa for some reason I thought the scripts would just enumerate over the directories in recipes (like we do for building images

for recipe in $(ls ${__dirname}/../recipes/); do
docker build ${__dirname}/../recipes/${recipe}/ -t ${image_tag_pfx}${recipe}
done
) but there's an explicit list in
recipes=" \
headers \
x86 \
musl \
armv6l \
x64-pointer-compression \
x64-usdt \
.

FWIW The next release pre16 we have planned is next Tuesday (14.17.0, delayed for a week nodejs/node#38507 (comment)).

Fixes `ModuleNotFoundError: No module named 'distutils.spawn'` error.
@richardlau richardlau changed the title add armv6l-pre16 recipe to build list fixup armv6l recipes May 4, 2021
Copy link
Member

@rvagg rvagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw the reason for the explicit list is that we need to run fetch separately and not have it included in this phase, but also that there's a sense of importance to the builds and because they're queued it's good to get the more important ones out first (although I don't recall whether we ended up with a "publish what's available" system or wait until they're all built - I'm also surprised that musl is not straight after headers since it's arguably much more important to get done ASAP).

@richardlau richardlau merged commit 6909a6a into nodejs:master May 5, 2021
@richardlau richardlau deleted the newarm branch May 5, 2021 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants